mirror of
https://github.com/harvard-edge/cs249r_book.git
synced 2026-07-16 14:42:29 -05:00
[GH-ISSUE #1613] [Bug] Milestone 3 advertises xor problem as solved even with 75% test accuracy #27925
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/cs249r_book#27925
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AndreaMattiaGaravagno on GitHub (Apr 30, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1613
Area
TinyTorch
Location
Milestone 3
Description
Milestone 3 advertises xor problem as solved even with 75% test accuracy
Expected Behavior
Milestone 3 should tell the user the training did not converge and suggest to re-run the milestone.
Environment (TinyTorch bugs only)
Tiny🔥Torch v0.1.10
Python 3.12.3
/home/andre/tinytorch/.venv
@profvjreddi commented on GitHub (Apr 30, 2026):
Fixed in #1618 (merged to dev as
f1d5a755f). Added a 0.95 convergence threshold; below that, the script now prints a yellow "Training Did Not Converge" panel telling the student to re-run and warning them not to move on to TinyDigits on a broken result. The "✅ Perfect XOR solution!" message no longer fires at 75%.