github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-18 00:44:29 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1856] [MERGED] fix(staffml): mount the command palette and shortcuts overlay #27318

New Issue
Closed
opened 2026-06-18 16:54:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-18 16:54:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1856
Author: @farhan523
Created: 6/12/2026
Status: ✅ Merged
Merged: 6/16/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/staffml-mount-command-palette

📝 Commits (1)

  • 06b6679 fix(staffml): mount the command palette and shortcuts overlay

📊 Changes

2 files changed (+64 additions, -0 deletions)

View changed files

📝 interviews/staffml/src/app/layout.tsx (+8 -0)
➕ interviews/staffml/tests/command-palette.spec.ts (+56 -0)

📄 Description

Problem

CommandPalette and KeyboardShortcutsOverlay were added in the client-UX overhaul (cefa8bfe63) — complete with unit tests and docblocks stating they are "mounted in app/layout.tsx" — but the mount line was never actually added. git log -S CommandPalette -- src/app/layout.tsx returns nothing: they have been dead since introduction.

As a result, on every route:

  • the navbar search icon dispatches staffml:open-palette into the void (no listener mounted),
  • Cmd/Ctrl+K does nothing,
  • ? does nothing.

Fix

Render both overlays once in RootLayout, inside <Providers> so the palette can read the vault via useVault() (it would throw outside CorpusProvider).

Test

Adds a Playwright smoke test (tests/command-palette.spec.ts) covering the three previously-dead entry points: Ctrl+K, the navbar search icon, and ?. tsc --noEmit is clean.

How to verify

  1. npm run dev, open any page.
  2. Click the navbar search icon or press Ctrl/Cmd+K → palette opens.
  3. Press ? → keyboard-shortcuts overlay opens. Esc closes either.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1856 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 6/12/2026 **Status:** ✅ Merged **Merged:** 6/16/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/staffml-mount-command-palette` --- ### 📝 Commits (1) - [`06b6679`](https://github.com/harvard-edge/cs249r_book/commit/06b667937d4a5a097208902939b566444734daee) fix(staffml): mount the command palette and shortcuts overlay ### 📊 Changes **2 files changed** (+64 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `interviews/staffml/src/app/layout.tsx` (+8 -0) ➕ `interviews/staffml/tests/command-palette.spec.ts` (+56 -0) </details> ### 📄 Description ## Problem `CommandPalette` and `KeyboardShortcutsOverlay` were added in the client-UX overhaul (`cefa8bfe63`) — complete with unit tests and docblocks stating they are *"mounted in `app/layout.tsx`"* — but the mount line was never actually added. `git log -S CommandPalette -- src/app/layout.tsx` returns nothing: they have been dead since introduction. As a result, on **every** route: - the navbar search icon dispatches `staffml:open-palette` into the void (no listener mounted), - **Cmd/Ctrl+K** does nothing, - **`?`** does nothing. ## Fix Render both overlays once in `RootLayout`, inside `<Providers>` so the palette can read the vault via `useVault()` (it would throw outside `CorpusProvider`). ## Test Adds a Playwright smoke test (`tests/command-palette.spec.ts`) covering the three previously-dead entry points: Ctrl+K, the navbar search icon, and `?`. `tsc --noEmit` is clean. ## How to verify 1. `npm run dev`, open any page. 2. Click the navbar search icon **or** press **Ctrl/Cmd+K** → palette opens. 3. Press **`?`** → keyboard-shortcuts overlay opens. **Esc** closes either. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-18 16:54:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#27318
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?