github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-18 17:03:56 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1854] fixes for tinytorch modules 07 and 08 as well as some rewording for lab 01 #27317

New Issue
Open
opened 2026-06-18 16:54:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-18 16:54:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1854
Author: @vedant-a-joshi
Created: 6/10/2026
Status: 🔄 Open

Base: dev ← Head: fix/tinytorch-modules-and-labs

📝 Commits (3)

  • dafadd0 lab 01 fixes and minor rewording
  • 7f44ee1 tinytorch modules 07 and 08 diagram fixes
  • 737840a Update contributors list [skip ci]

📊 Changes

5 files changed (+149 additions, -149 deletions)

View changed files

📝 .all-contributorsrc (+1 -1)
📝 labs/vol1/lab_01_ml_intro.py (+17 -15)
📝 site/about/contributors.json (+5 -5)
📝 tinytorch/src/07_optimizers/07_optimizers.py (+73 -77)
📝 tinytorch/src/08_training/08_training.py (+53 -51)

📄 Description

Tested through tito module test NN for modules 07 and 08.
Note: It fails FAILED tests/integration/test_training_flow.py::TestTrainingReducesLoss::test_mlp_loss_decreases, however the commits here aren't meant to fix this, and they shouldn't be altering/causing it in any way.

I manually checked to make sure the new diagrams and wording is accurate.

Changes for tinytorch

  • Fixed diagram representations for easier understanding
  • Fixed alignment/consistency issues

Changes for labs

  • Fixed duration so that it adds up in the correct spot
  • Fixed equation representation
  • Fixed graph so that logarithm y-axis so that y-axis is easier to understand

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1854 **Author:** [@vedant-a-joshi](https://github.com/vedant-a-joshi) **Created:** 6/10/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `fix/tinytorch-modules-and-labs` --- ### 📝 Commits (3) - [`dafadd0`](https://github.com/harvard-edge/cs249r_book/commit/dafadd0e9c4fb4b2119cd0447f8f8ba4b1e0d9f5) lab 01 fixes and minor rewording - [`7f44ee1`](https://github.com/harvard-edge/cs249r_book/commit/7f44ee1a278ef018722024916aa00adb25230380) tinytorch modules 07 and 08 diagram fixes - [`737840a`](https://github.com/harvard-edge/cs249r_book/commit/737840a93a7a3c4b3633415847e85f8d5287c80c) Update contributors list [skip ci] ### 📊 Changes **5 files changed** (+149 additions, -149 deletions) <details> <summary>View changed files</summary> 📝 `.all-contributorsrc` (+1 -1) 📝 `labs/vol1/lab_01_ml_intro.py` (+17 -15) 📝 `site/about/contributors.json` (+5 -5) 📝 `tinytorch/src/07_optimizers/07_optimizers.py` (+73 -77) 📝 `tinytorch/src/08_training/08_training.py` (+53 -51) </details> ### 📄 Description Tested through `tito module test NN` for modules 07 and 08. _Note_: It fails FAILED tests/integration/test_training_flow.py::TestTrainingReducesLoss::test_mlp_loss_decreases, however the commits here aren't meant to fix this, and they shouldn't be altering/causing it in any way. I manually checked to make sure the new diagrams and wording is accurate. Changes for tinytorch * Fixed diagram representations for easier understanding * Fixed alignment/consistency issues Changes for labs * Fixed duration so that it adds up in the correct spot * Fixed equation representation * Fixed graph so that logarithm y-axis so that y-axis is easier to understand --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-18 16:54:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#27317
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?