github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-16 23:24:55 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1747] [MERGED] Fix navbar dropdown styling #26135

New Issue
Closed
opened 2026-06-15 04:53:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-15 04:53:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1747
Author: @farhan523
Created: 5/16/2026
Status: ✅ Merged
Merged: 5/16/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/mlsysim-darkmode-dropdown

📝 Commits (1)

  • 6cd7d5c Fix dark mode navbar dropdown styling

📊 Changes

1 file changed (+25 additions, -0 deletions)

View changed files

📝 mlsysim/docs/styles/dark-mode.scss (+25 -0)

📄 Description

Summary
Fix the MLSysim dark-mode navbar dropdown so menu items remain readable and the dropdown matches the rest of the dark theme.

Changes

  • add explicit dark-mode styles for navbar dropdown menus
  • set readable dropdown text colors in dark mode
  • add hover/focus and divider styling for dropdown items

Before:
Screenshot 2026-05-16 100008

After:

Screenshot 2026-05-16 100014

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1747 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/16/2026 **Status:** ✅ Merged **Merged:** 5/16/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/mlsysim-darkmode-dropdown` --- ### 📝 Commits (1) - [`6cd7d5c`](https://github.com/harvard-edge/cs249r_book/commit/6cd7d5c6b743bbf6e342f7a0e56ca26e1a8c5e14) Fix dark mode navbar dropdown styling ### 📊 Changes **1 file changed** (+25 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `mlsysim/docs/styles/dark-mode.scss` (+25 -0) </details> ### 📄 Description Summary Fix the MLSysim dark-mode navbar dropdown so menu items remain readable and the dropdown matches the rest of the dark theme. Changes - add explicit dark-mode styles for navbar dropdown menus - set readable dropdown text colors in dark mode - add hover/focus and divider styling for dropdown items Before: <img width="355" height="210" alt="Screenshot 2026-05-16 100008" src="https://github.com/user-attachments/assets/e621a2c9-2065-41f8-b41d-b2f6bf44bd25" /> After: <img width="418" height="297" alt="Screenshot 2026-05-16 100014" src="https://github.com/user-attachments/assets/b0627b8b-23ec-431c-ab3c-9017324a709b" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-15 04:53:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#26135
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?