[PR #1600] [MERGED] fix(ci/staffml): validate trailing-slash page paths in dev preview #26002

Closed
opened 2026-06-15 04:45:58 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1600
Author: @profvjreddi
Created: 4/29/2026
Status: Merged
Merged: 4/29/2026
Merged by: @profvjreddi

Base: devHead: fix/staffml-missing-pages


📝 Commits (1)

  • a963ceb fix(ci/staffml): validate trailing-slash page paths in dev preview

📊 Changes

1 file changed (+12 additions, -4 deletions)

View changed files

📝 .github/workflows/staffml-preview-dev.yml (+12 -4)

📄 Description

Summary

  • The dev preview deploy was failing at the validate-build step because it checked for out/<page>.html, but next.config.mjs sets trailingSlash: true — Next.js emits out/<page>/index.html. The build itself was always fine; only the validator was wrong.
  • Updated the loop to check <page>/index.html for the four content pages (practice / gauntlet / progress / about) and keep 404.html as the flat exception. Mirrors the check already in staffml-validate-dev.yml.

Context

Failing run that motivated the fix: https://github.com/harvard-edge/cs249r_book/actions/runs/25106312447

Test plan

  • Built StaffML locally with the same env vars as CI (NEXT_PUBLIC_BASE_PATH=/cs249r_book_dev/staffml, etc.) — 16 pages, 15M, identical to the failing run.
  • Ran the fixed validator logic against the local out/ — all four <page>/index.html files plus 404.html resolve.
  • Watch the preview-dev workflow re-run on this branch / after merge.

🤖 Generated with Claude Code


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1600 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 4/29/2026 **Status:** ✅ Merged **Merged:** 4/29/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/staffml-missing-pages` --- ### 📝 Commits (1) - [`a963ceb`](https://github.com/harvard-edge/cs249r_book/commit/a963ceb80d0e04d080335573c9d9262f01a606ca) fix(ci/staffml): validate trailing-slash page paths in dev preview ### 📊 Changes **1 file changed** (+12 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/staffml-preview-dev.yml` (+12 -4) </details> ### 📄 Description ## Summary - The dev preview deploy was failing at the validate-build step because it checked for `out/<page>.html`, but `next.config.mjs` sets `trailingSlash: true` — Next.js emits `out/<page>/index.html`. The build itself was always fine; only the validator was wrong. - Updated the loop to check `<page>/index.html` for the four content pages (practice / gauntlet / progress / about) and keep `404.html` as the flat exception. Mirrors the check already in `staffml-validate-dev.yml`. ## Context Failing run that motivated the fix: https://github.com/harvard-edge/cs249r_book/actions/runs/25106312447 ## Test plan - [x] Built StaffML locally with the same env vars as CI (`NEXT_PUBLIC_BASE_PATH=/cs249r_book_dev/staffml`, etc.) — 16 pages, 15M, identical to the failing run. - [x] Ran the fixed validator logic against the local `out/` — all four `<page>/index.html` files plus `404.html` resolve. - [ ] Watch the preview-dev workflow re-run on this branch / after merge. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-15 04:45:58 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#26002