github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-21 13:31:55 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1192] [MERGED] feat: add type hints to modules 03, 04, and 05 (#1167) #2386

New Issue
Closed
opened 2026-04-11 08:26:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 08:26:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1192
Author: @imuday984
Created: 2/21/2026
Status: ✅ Merged
Merged: 3/20/2026
Merged by: @profvjreddi

Base: dev ← Head: feature/type-hints-03-04

📝 Commits (2)

  • 4888cae feat: add type hints to 03_layers and 04_losses (#1167)
  • 9b01eb1 feat: add type hints to 05_dataloader

📊 Changes

3 files changed (+82 additions, -49 deletions)

View changed files

📝 tinytorch/src/03_layers/03_layers.py (+52 -29)
📝 tinytorch/src/04_losses/04_losses.py (+18 -8)
📝 tinytorch/src/05_dataloader/05_dataloader.py (+12 -12)

📄 Description

Resolves #1167 for modules 03 and 04.

Following the discussion with @harishb00 in my previous PR, I have left 01_tensor and 02_activations for them to push. I have applied the suggested future imports and TypeAlias patterns to these new modules for cleaner code.

Note: I added these directly to the source files (src/) but haven't run the tito module complete build step locally to update the generated package files. Let me know if a maintainer can trigger the build.
thank you.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1192 **Author:** [@imuday984](https://github.com/imuday984) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 3/20/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `feature/type-hints-03-04` --- ### 📝 Commits (2) - [`4888cae`](https://github.com/harvard-edge/cs249r_book/commit/4888caef76fb4999a404c6f9c2eb8100d200efd1) feat: add type hints to 03_layers and 04_losses (#1167) - [`9b01eb1`](https://github.com/harvard-edge/cs249r_book/commit/9b01eb1a1e686415ed0fc7736ea4f16dc3545457) feat: add type hints to 05_dataloader ### 📊 Changes **3 files changed** (+82 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/src/03_layers/03_layers.py` (+52 -29) 📝 `tinytorch/src/04_losses/04_losses.py` (+18 -8) 📝 `tinytorch/src/05_dataloader/05_dataloader.py` (+12 -12) </details> ### 📄 Description Resolves #1167 for modules 03 and 04. Following the discussion with @harishb00 in my previous PR, I have left 01_tensor and 02_activations for them to push. I have applied the suggested __future__ imports and TypeAlias patterns to these new modules for cleaner code. Note: I added these directly to the source files (src/) but haven't run the tito module complete build step locally to update the generated package files. Let me know if a maintainer can trigger the build. thank you. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 08:26:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#2386
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?