github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-16 14:42:29 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[GH-ISSUE #1611] [Bug] Milestone 1: the weights of the Perceptron never change #21567

New Issue
Closed
opened 2026-06-04 21:26:59 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-06-04 21:26:59 -05:00
Owner
Copy Link

Originally created by @AndreaMattiaGaravagno on GitHub (Apr 30, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1611

Area

TinyTorch

Location

Milestone 1

Description

Milestone 1: the weights of the Perceptron never change

Expected Behavior

The weights of the Perceptron should change between different runs

Environment (TinyTorch bugs only)

Tiny🔥Torch v0.1.10
Python 3.12.3
/home/andre/tinytorch/.venv

Originally created by @AndreaMattiaGaravagno on GitHub (Apr 30, 2026). Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1611 ### Area TinyTorch ### Location Milestone 1 ### Description Milestone 1: the weights of the Perceptron never change ### Expected Behavior The weights of the Perceptron should change between different runs ### Environment (TinyTorch bugs only) Tiny🔥Torch v0.1.10 Python 3.12.3 /home/andre/tinytorch/.venv
GiteaMirror added the area: tinytorchtype: bug labels 2026-06-04 21:27:00 -05:00
GiteaMirror commented 2026-06-04 21:27:03 -05:00
Author
Owner
Copy Link

@profvjreddi commented on GitHub (Apr 30, 2026):

Fixed in #1617 (merged to dev as cb68c293d). Module-level rng = np.random.default_rng(7) in tinytorch/src/03_layers/03_layers.py was reused by every Linear() weight init, making weights deterministic across runs despite the milestone's on-screen "no random seed" message. Both that seed and the milestone's own data RNG seed are now unseeded. Verified by two-run diff: weights and accuracy now vary.

<!-- gh-comment-id:4356773998 --> @profvjreddi commented on GitHub (Apr 30, 2026): Fixed in #1617 (merged to dev as cb68c293d). Module-level `rng = np.random.default_rng(7)` in `tinytorch/src/03_layers/03_layers.py` was reused by every `Linear()` weight init, making weights deterministic across runs despite the milestone's on-screen "no random seed" message. Both that seed and the milestone's own data RNG seed are now unseeded. Verified by two-run diff: weights and accuracy now vary.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label area: tinytorch type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#21567
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?