github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-18 00:44:29 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1798] [MERGED] fix(book): wrap long URLs to stop horizontal page overflow #19218

New Issue
Closed
opened 2026-05-28 22:43:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-28 22:43:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1798
Author: @farhan523
Created: 5/23/2026
Status: ✅ Merged
Merged: 5/27/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/book-long-url-horizontal-overflow

📝 Commits (1)

  • cd910e4 fix(book): wrap long URLs to stop horizontal page overflow

📊 Changes

3 files changed (+47 additions, -0 deletions)

View changed files

📝 book/quarto/assets/styles/_base-styles.scss (+19 -0)
📝 shared/styles/partials/_links.scss (+12 -0)
📝 shared/styles/partials/_toc.scss (+16 -0)

📄 Description

Summary

On reference-heavy chapters (e.g. vol1 training), long unbreakable tokens — paper hashes (https://proceedings.neurips.cc/paper/2012/hash/6aca97005c68f1206823815f66102863-Abstract.html), arXiv ids, DOI suffixes — inside body links, column-margin notes, footnotes, callouts, and right-side TOC entries inflated the line box past their column width. That cascaded into page-level horizontal scroll on narrower viewports.

Fix: add overflow-wrap: anywhere to the global a rule and the TOC container so unbreakable tokens wrap inside their column instead of forcing the page wider.

Where the change goes

  • book/quarto/assets/styles/_base-styles.scss — the volume builds (vol1 + vol2) use this file. It carries duplicated TOC/link rules and does not import the shared partials, so the fix has to be applied here directly.
  • shared/styles/partials/_links.scss and shared/styles/partials/_toc.scss — the corresponding shared partials, for ecosystem sites that do consume them (site, tinytorch, labs, kits, instructors, slides, mlsysim docs). Defensive parity so the same regression doesn't reappear in those builds later.

Why anywhere (not break-word)

Only overflow-wrap: anywhere shrinks an element's min-content size, so flex/grid ancestors can actually narrow the column. break-word would still let the long URL define the column's min-content, and the overflow would persist on small viewports. Paired with min-width: 0 on the TOC container so the column is allowed to take the smaller size. Regular prose still breaks at word boundaries first; mid-token splits only kick in when nothing else fits.

Test plan

  • Open the vol1 training chapter (/vol1/contents/vol1/training/training.html) on a narrow viewport (~375 px).
  • Confirm no horizontal page scroll where the long neurips paper URL appears.
  • Confirm long URLs in margin-notes, footnotes, callouts, and the right-side TOC wrap inside their column.
  • Regular short links and prose look unchanged.
  • Spot-check vol2 (uses the same _base-styles.scss).
  • Spot-check an ecosystem Quarto site that consumes the shared partials (e.g. site/) for any regression.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1798 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/23/2026 **Status:** ✅ Merged **Merged:** 5/27/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/book-long-url-horizontal-overflow` --- ### 📝 Commits (1) - [`cd910e4`](https://github.com/harvard-edge/cs249r_book/commit/cd910e446fee9ebc3b8d2bb0389ab2a21aefdb7c) fix(book): wrap long URLs to stop horizontal page overflow ### 📊 Changes **3 files changed** (+47 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `book/quarto/assets/styles/_base-styles.scss` (+19 -0) 📝 `shared/styles/partials/_links.scss` (+12 -0) 📝 `shared/styles/partials/_toc.scss` (+16 -0) </details> ### 📄 Description ## Summary On reference-heavy chapters (e.g. **vol1 training**), long unbreakable tokens — paper hashes (`https://proceedings.neurips.cc/paper/2012/hash/6aca97005c68f1206823815f66102863-Abstract.html`), arXiv ids, DOI suffixes — inside body links, column-margin notes, footnotes, callouts, and right-side TOC entries inflated the line box past their column width. That cascaded into **page-level horizontal scroll** on narrower viewports. Fix: add `overflow-wrap: anywhere` to the global `a` rule and the TOC container so unbreakable tokens wrap inside their column instead of forcing the page wider. ### Where the change goes - **`book/quarto/assets/styles/_base-styles.scss`** — the volume builds (vol1 + vol2) use this file. It carries duplicated TOC/link rules and does **not** import the shared partials, so the fix has to be applied here directly. - **`shared/styles/partials/_links.scss`** and **`shared/styles/partials/_toc.scss`** — the corresponding shared partials, for ecosystem sites that do consume them (site, tinytorch, labs, kits, instructors, slides, mlsysim docs). Defensive parity so the same regression doesn't reappear in those builds later. ### Why `anywhere` (not `break-word`) Only `overflow-wrap: anywhere` shrinks an element's **min-content size**, so flex/grid ancestors can actually narrow the column. `break-word` would still let the long URL define the column's min-content, and the overflow would persist on small viewports. Paired with `min-width: 0` on the TOC container so the column is allowed to take the smaller size. Regular prose still breaks at word boundaries first; mid-token splits only kick in when nothing else fits. ## Test plan - [ ] Open the vol1 training chapter (`/vol1/contents/vol1/training/training.html`) on a narrow viewport (~375 px). - [ ] Confirm no horizontal page scroll where the long neurips paper URL appears. - [ ] Confirm long URLs in margin-notes, footnotes, callouts, and the right-side TOC wrap inside their column. - [ ] Regular short links and prose look unchanged. - [ ] Spot-check vol2 (uses the same `_base-styles.scss`). - [ ] Spot-check an ecosystem Quarto site that consumes the shared partials (e.g. `site/`) for any regression. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-28 22:43:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#19218
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?