mirror of
https://github.com/harvard-edge/cs249r_book.git
synced 2026-07-20 01:01:30 -05:00
[PR #1537] [MERGED] fix(tinytorch/site): site-wide dark-mode coverage + framework version chip #18977
Closed
opened 2026-05-28 22:32:51 -05:00 by GiteaMirror
·
0 comments
No Branch/Tag Specified
dev
audit/mlperf-edu-readiness
feat/mlperf-edu-precondition
gh-pages
vol1/all-final
main
vol1/appendices-final
vol1/ch16-final
vol1/ch15-final
vol1/ch14-final
vol1/ch13-final
vol1/ch11-final
vol1/ch12-final
vol1/ch10-final
vol1/ch9-final
vol1/ch8-final
vol1/ch7-final
vol1/ch6-final
vol1/ch5-final
vol1/ch4-final
vol1/ch3-final
vol1/ch2-final
vol1/frontmater-final
kai/fixing-profile-setting-and-map
chore/staffml-ci-path
fix/callout-flow
vol1/ch10-pass4
vol1/ch9-pass4
vol1/ch8-pass4
vol1/ch7-pass4
vol1/ch6-pass4
vol1/ch5-pass4
vol1/apC-pass3
vol1/ch4-pass4
vol1/ch3-pass4
vol1/ch2-pass4
vol1/ch1-pass4
vol1/frontmatter
vol1/apE-pass3
vol1/apD-pass3
fmt-fix
vol1/ch14-pass3
kai/clarify-community-map-totals
vol1/ch13-pass3
vol1/ch12-pass3
vol1/ch11-pass3
vol1/ch10-pass3
vol1/ch7-pass3
vol1/ch9-pass3
vol1/ch8-pass3
vol1/ch6-pass3
vol1/ch5-pass3
vol1/ch4-pass3
vol1/ch3-pass3
vol1/ch2-pass3
vol1/ch1-pass3
vol1/ch6-pass2
vol1/ch5-pass2
vol1/ch4-pass2
vol1/ch3-pass2
vol1/ch2-pass2
fix/badge-fixes
chore/precommit-cleanup
cleanup/book-validate-paths
fix/staffml-trigger-on-workflow-edits
fix/staffml-reusable-concurrency
feat/container-preflight-urls
instructors-v0.1.1
vol1-pr1957-merged
vol2-v0.2.1
vol1-v0.7.1
vol1-v0.7.0+vol2-v0.2.0
slides-v0.1.0
vol2-v0.2.0
vol1-v0.7.0
tinytorch-v0.1.13
mlsysim-v0.2.0
vol2-v0.1.2
vol1-v0.6.2
tinytorch-v0.1.12
vol2-v0.1.1
vol1-v0.6.1
mlsysim-v0.1.3
vol2-v0.1.0
vol1-v0.6.0
mlsysim-v0.1.2
staffml-v0.1.1
tinytorch-v0.1.11
labs-v0.1.0
kits-v0.1.0
slides-latest
instructors-v0.1.0
staffml-v0.1.0
mlsysim-v0.1.1
mlsysim-v0.1.0
tinytorch-v0.1.10
build-verified-windows-v1
tinytorch-v0.1.9
tinytorch-v0.1.8
mit-submission-v1
tinytorch-v0.1.7
tinytorch-v0.1.6
tinytorch-v0.1.5
tinytorch-slides-v0.1.0
tinytorch-v0.1.3
tinytorch-v0.1.4
tinytorch-v0.1.2
tinytorch-v0.1.1
tinytorch-v0.1.0
book-v0.5.1
tinytorch-audio-v0.1.1
tinytorch-audio-assets-v0.1
book-v0.5.0
book-v0.4.2
book-v0.4.1
book-v0.4.0
book-v0.3.0
book-v0.2.0
book-v0.1.0
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
Mirrored from GitHub Pull Request
No labels
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/cs249r_book#18977
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/harvard-edge/cs249r_book/pull/1537
Author: @profvjreddi
Created: 4/25/2026
Status: ✅ Merged
Merged: 4/25/2026
Merged by: @profvjreddi
Base:
dev← Head:fix/tinytorch-tito-dark-mode📝 Commits (3)
4c2996efix(tinytorch/ux): restore dark-mode contrast on tito/milestones page2707c05fix(tinytorch/ux): site-wide dark-mode coverage for sidebar + inline-fill panels72d2163feat(tinytorch/site): persistent framework version chip in sidebar📊 Changes
3 files changed (+173 additions, -23 deletions)
View changed files
📝
tinytorch/quarto/assets/scripts/sidebar-subtitle.html(+70 -8)📝
tinytorch/quarto/assets/styles/dark-mode.scss(+84 -0)📝
tinytorch/quarto/tito/milestones.qmd(+19 -15)📄 Description
Summary
Three commits on this branch addressing the dark-mode follow-ups from #1529 and adding a persistent framework version indicator. Site-only change — no Python package code touched, no version bump, no PyPI release.
4c2996e0dtito/milestones.qmdinline-style panels to.who-card/.callout-note(follows the pattern #1529 established forpreface.qmd)2707c0546.who-cardborder72d2163a7Why
After #1529 fixed
preface.qmd, three structural gaps remained on every other TinyTorch site page:dark-mode.scssdeclared\$sidebar-bg-darkbut never applied it to a selector. White sidebar on every page..qmdfiles (`background: #f8f9fa` etc. beats class specificity).config/announcement.ymlheader).How
tito/milestones.qmd) following the #1529 pattern — establishes the pattern, reduces inline styles 14 → 10 (the 10 remaining are intentional mode-invariant accents).dark-mode.scss—[style*=\"background: #X\"]attribute selectors for the 14 light-fill hex values used inline across the corpus, plus 8 dark-grey text colors. Catches every page in dark mode without touching individual.qmdfiles. `!important` is required because inlinestyle=beats class specificity.#D4740Clight /#F59E0Bdark) below the existing subtitle, prefixed with `🔥 TinyTorch` so it cannot be mis-read as the textbook's version. Clicks open GitHub Releases filtered for `tinytorch` tags. Source: hardcoded with aTINYTORCH_VERSION_CHIPsed marker for future bumps.Verification (Playwright, full-page screenshots, computed-style assertions)
indexbig-picturetito/milestonestito/overviewtito/troubleshootingSidebar version chip verified on
index+tito/milestones:color: rgb(212, 116, 12)=#D4740C✓color: rgb(245, 158, 11)=#F59E0B✓href=https://github.com/harvard-edge/cs249r_book/releases?q=tinytorch✓target=\"_blank\" rel=\"noopener\"✓🔥 TinyTorchprefix)Deployment
Site-only deploy via existing
tinytorch-publish-liveworkflow withsite_only: true— skips version bump, tag, PDF build, GitHub release. Just renders Quarto and pushes togh-pages/tinytorch/.Known follow-ups (deferred, not blocking)
tito/overview/data/modules/troubleshooting.qmd(~140 inline styles total) — code-cleanliness improvement, safety net mitigates user-visible bug now.\$accentSCSS cascade question from #1529 — static analysis suggests it's fine; render-time verification deferred.sidebar-subtitle.htmlto the publish workflow'sUPDATE_VERSIONstep's sed list so the chip auto-bumps withsettings.inion each future release.Test plan
quarto rendersucceeds across rendered pages (index, big-picture, tito/milestones, tito/overview, tito/troubleshooting)tinytorch-publish-livewithsite_only: trueto deploy🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.