github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-17 08:28:07 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1202] [MERGED] Fix incorrect matrix multiplication computation in notebook example #18715

New Issue
Closed
opened 2026-05-28 22:20:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-28 22:20:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1202
Author: @adityamulik
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @profvjreddi

Base: dev ← Head: module_1_doc_fix

📝 Commits (1)

  • e5d8395 The multiplication process example is corrected

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 tinytorch/src/01_tensor/01_tensor.py (+5 -5)

📄 Description

Corrected arithmetic error in matrix multiplication example.

The previous implementation had an incorrect term in the computation of C[1,1]
(second row, second column).
Updated the calculation to correctly follow row × column dot product logic.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1202 **Author:** [@adityamulik](https://github.com/adityamulik) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `module_1_doc_fix` --- ### 📝 Commits (1) - [`e5d8395`](https://github.com/harvard-edge/cs249r_book/commit/e5d83952654e6112f90f618b5fe3c0aa24b86ae3) The multiplication process example is corrected ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/src/01_tensor/01_tensor.py` (+5 -5) </details> ### 📄 Description Corrected arithmetic error in matrix multiplication example. The previous implementation had an incorrect term in the computation of C[1,1] (second row, second column). Updated the calculation to correctly follow row × column dot product logic. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-28 22:20:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#18715
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?