github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-17 08:28:07 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1094] [MERGED] Security: mitigate shell injection in build-baremetal #18659

New Issue
Closed
opened 2026-05-28 22:17:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-28 22:17:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1094
Author: @RinZ27
Created: 1/1/2026
Status: ✅ Merged
Merged: 1/2/2026
Merged by: @profvjreddi

Base: main ← Head: security/fix-shell-injection

📝 Commits (1)

  • 19bc61e Security: mitigate shell injection in build workflow

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 .github/workflows/book-build-baremetal.yml (+4 -3)

📄 Description

Move artifact name evaluation to env context.

Interpolating inputs.artifact_name directly into the shell script is unsafe as it allows for potential command injection. By using an intermediate environment variable, the value is handled as data rather than executable code during shell expansion.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1094 **Author:** [@RinZ27](https://github.com/RinZ27) **Created:** 1/1/2026 **Status:** ✅ Merged **Merged:** 1/2/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `main` ← **Head:** `security/fix-shell-injection` --- ### 📝 Commits (1) - [`19bc61e`](https://github.com/harvard-edge/cs249r_book/commit/19bc61ee4e90f98f73936f62cf5554dd0a94e963) Security: mitigate shell injection in build workflow ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/book-build-baremetal.yml` (+4 -3) </details> ### 📄 Description Move artifact name evaluation to `env` context. Interpolating `inputs.artifact_name` directly into the shell script is unsafe as it allows for potential command injection. By using an intermediate environment variable, the value is handled as data rather than executable code during shell expansion. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-28 22:17:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#18659
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?