github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-18 00:44:29 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[GH-ISSUE #1531] fix(ci): labs still reference mlsysim-0.1.0 wheel after pyproject bumped to 0.1.1 #18051

New Issue
Closed
opened 2026-05-28 21:48:20 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-05-28 21:48:20 -05:00
Owner
Copy Link

Originally created by @Shashank-Tripathi-07 on GitHub (Apr 25, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1531

Problem

PR #1523 bumped mlsysim/pyproject.toml to version 0.1.1 but the micropip.install() calls in all lab files were not updated. Every lab still hardcodes:

await micropip.install("../../wheels/mlsysim-0.1.0-py3-none-any.whl", ...)

The TestWheelConsistency test in labs/tests/test_static.py correctly catches this and is now failing on every PR that touches the repo, including unrelated ones.

Failing checks

  • 🧪 Validate Notebooks: TestWheelConsistency::test_micropip_url_matches_pyproject_version fails for all 33 labs
  • 🌐 WASM Export Smoke Test: cascades from the wrong wheel being loaded

Fix

Bulk-replace mlsysim-0.1.0-py3-none-any.whl with mlsysim-0.1.1-py3-none-any.whl across all lab files under labs/vol1/ and labs/vol2/.

One-liner:

grep -rl "mlsysim-0.1.0-py3-none-any.whl" labs/ | xargs sed -i 's/mlsysim-0.1.0-py3-none-any.whl/mlsysim-0.1.1-py3-none-any.whl/g'

Going forward, this update should be part of the mlsysim release checklist so it stays in sync with pyproject.toml.

Originally created by @Shashank-Tripathi-07 on GitHub (Apr 25, 2026). Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1531 ## Problem PR #1523 bumped `mlsysim/pyproject.toml` to version `0.1.1` but the `micropip.install()` calls in all lab files were not updated. Every lab still hardcodes: ```python await micropip.install("../../wheels/mlsysim-0.1.0-py3-none-any.whl", ...) ``` The `TestWheelConsistency` test in `labs/tests/test_static.py` correctly catches this and is now failing on every PR that touches the repo, including unrelated ones. ## Failing checks - `🧪 Validate Notebooks`: `TestWheelConsistency::test_micropip_url_matches_pyproject_version` fails for all 33 labs - `🌐 WASM Export Smoke Test`: cascades from the wrong wheel being loaded ## Fix Bulk-replace `mlsysim-0.1.0-py3-none-any.whl` with `mlsysim-0.1.1-py3-none-any.whl` across all lab files under `labs/vol1/` and `labs/vol2/`. One-liner: ```bash grep -rl "mlsysim-0.1.0-py3-none-any.whl" labs/ | xargs sed -i 's/mlsysim-0.1.0-py3-none-any.whl/mlsysim-0.1.1-py3-none-any.whl/g' ``` Going forward, this update should be part of the mlsysim release checklist so it stays in sync with `pyproject.toml`.
GiteaMirror added the area: toolstype: bug labels 2026-05-28 21:48:20 -05:00
GiteaMirror commented 2026-05-28 21:48:22 -05:00
Author
Owner
Copy Link

@profvjreddi commented on GitHub (Apr 25, 2026):

🚀

<!-- gh-comment-id:4319653397 --> @profvjreddi commented on GitHub (Apr 25, 2026): 🚀
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label area: tools type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#18051
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?