mirror of
https://github.com/harvard-edge/cs249r_book.git
synced 2026-07-20 04:45:11 -05:00
Closed
opened 2026-04-11 08:06:30 -05:00 by GiteaMirror
·
7 comments
No Branch/Tag Specified
dev
audit/mlperf-edu-readiness
feat/mlperf-edu-precondition
gh-pages
vol1/all-final
main
vol1/appendices-final
vol1/ch16-final
vol1/ch15-final
vol1/ch14-final
vol1/ch13-final
vol1/ch11-final
vol1/ch12-final
vol1/ch10-final
vol1/ch9-final
vol1/ch8-final
vol1/ch7-final
vol1/ch6-final
vol1/ch5-final
vol1/ch4-final
vol1/ch3-final
vol1/ch2-final
vol1/frontmater-final
kai/fixing-profile-setting-and-map
chore/staffml-ci-path
fix/callout-flow
vol1/ch10-pass4
vol1/ch9-pass4
vol1/ch8-pass4
vol1/ch7-pass4
vol1/ch6-pass4
vol1/ch5-pass4
vol1/apC-pass3
vol1/ch4-pass4
vol1/ch3-pass4
vol1/ch2-pass4
vol1/ch1-pass4
vol1/frontmatter
vol1/apE-pass3
vol1/apD-pass3
fmt-fix
vol1/ch14-pass3
kai/clarify-community-map-totals
vol1/ch13-pass3
vol1/ch12-pass3
vol1/ch11-pass3
vol1/ch10-pass3
vol1/ch7-pass3
vol1/ch9-pass3
vol1/ch8-pass3
vol1/ch6-pass3
vol1/ch5-pass3
vol1/ch4-pass3
vol1/ch3-pass3
vol1/ch2-pass3
vol1/ch1-pass3
vol1/ch6-pass2
vol1/ch5-pass2
vol1/ch4-pass2
vol1/ch3-pass2
vol1/ch2-pass2
fix/badge-fixes
chore/precommit-cleanup
cleanup/book-validate-paths
fix/staffml-trigger-on-workflow-edits
fix/staffml-reusable-concurrency
feat/container-preflight-urls
instructors-v0.1.1
vol1-pr1957-merged
vol2-v0.2.1
vol1-v0.7.1
vol1-v0.7.0+vol2-v0.2.0
slides-v0.1.0
vol2-v0.2.0
vol1-v0.7.0
tinytorch-v0.1.13
mlsysim-v0.2.0
vol2-v0.1.2
vol1-v0.6.2
tinytorch-v0.1.12
vol2-v0.1.1
vol1-v0.6.1
mlsysim-v0.1.3
vol2-v0.1.0
vol1-v0.6.0
mlsysim-v0.1.2
staffml-v0.1.1
tinytorch-v0.1.11
labs-v0.1.0
kits-v0.1.0
slides-latest
instructors-v0.1.0
staffml-v0.1.0
mlsysim-v0.1.1
mlsysim-v0.1.0
tinytorch-v0.1.10
build-verified-windows-v1
tinytorch-v0.1.9
tinytorch-v0.1.8
mit-submission-v1
tinytorch-v0.1.7
tinytorch-v0.1.6
tinytorch-v0.1.5
tinytorch-slides-v0.1.0
tinytorch-v0.1.3
tinytorch-v0.1.4
tinytorch-v0.1.2
tinytorch-v0.1.1
tinytorch-v0.1.0
book-v0.5.1
tinytorch-audio-v0.1.1
tinytorch-audio-assets-v0.1
book-v0.5.0
book-v0.4.2
book-v0.4.1
book-v0.4.0
book-v0.3.0
book-v0.2.0
book-v0.1.0
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
Mirrored from GitHub Pull Request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/cs249r_book#1743
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @Tess314 on GitHub (Mar 19, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1252
In the Model Optimizations chapter, I came across a mismatch between the values in Figure 13 and the text above describing it.
Text description: "As shown in Figure 13 performing a 32-bit floating-point addition (FAdd) consumes approximately 0.9 pJ, whereas a 16-bit floating-point addition only requires 0.4 pJ. Similarly, a 32-bit integer addition costs 0.1 pJ, while an 8-bit integer addition is significantly lower at just 0.03 pJ."
Figure 13 actual values:

Figure 13 shows integer operations, not floating-point operations. So either the figure or text needs changed to reflect this.
Hope this helps!
Tess
@profvjreddi commented on GitHub (Mar 28, 2026):
You rock! Thanks for taking a close look at this. This is fixed in the latest dev branch and will be resolved when I push the next release. I always wondered who would catch this — I knew I wanted to fix it, but kept telling myself, "I'll get to it." And finally, someone caught it! 😄 Love it when you folks find mistakes or "bugs" in the prose.
@all-contributors please add @Tess314 as a contributor for 🪲 Bug in Book
@github-actions[bot] commented on GitHub (Mar 28, 2026):
I've added @Tess314 as a contributor to book! 🎉
Recognized for: doc
Project(s): book (explicitly mentioned in comment)
Based on: @all-contributors please add @Tess314 as a contributor for 🪲 Bug in Book
The contributor list has been updated in:
book/.all-contributorsrc,book/README.mdREADME.mdWe love recognizing our contributors! ❤️
@Tess314 commented on GitHub (Mar 30, 2026):
Great, thank you!
@Tess314 commented on GitHub (Mar 30, 2026):
Hi @profvjreddi it looks like the README files haven't been updated to add me as contributor for 🪲 Bug in Book yet
@profvjreddi commented on GitHub (Apr 5, 2026):
Hey @Tess314 let me look into this. I'm curious why this is happening.
@profvjreddi commented on GitHub (Apr 5, 2026):
Thanks for flagging this—I’ve updated the contributor list so you’re credited as 🪲 Bug Hunter and ✍️ Doc Wizard, switched your entry to your GitHub profile photo (the old table used Gravatar identicons, not GitHub avatars), removed the duplicate name row, and linked your bug reports in the acknowledgements. 💪
Landed in commit
709f3aabdon dev (will be on main after the usual merge).@Tess314 commented on GitHub (Apr 6, 2026):
Awesome, thank you!