[GH-ISSUE #1252] Mismatched Figure 13 values in Model Optimizations chapter #1743

Closed
opened 2026-04-11 08:06:30 -05:00 by GiteaMirror · 7 comments
Owner

Originally created by @Tess314 on GitHub (Mar 19, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1252

In the Model Optimizations chapter, I came across a mismatch between the values in Figure 13 and the text above describing it.

Text description: "As shown in Figure 13 performing a 32-bit floating-point addition (FAdd) consumes approximately 0.9 pJ, whereas a 16-bit floating-point addition only requires 0.4 pJ. Similarly, a 32-bit integer addition costs 0.1 pJ, while an 8-bit integer addition is significantly lower at just 0.03 pJ."

Figure 13 actual values:
Image

Figure 13 shows integer operations, not floating-point operations. So either the figure or text needs changed to reflect this.

Hope this helps!
Tess

Originally created by @Tess314 on GitHub (Mar 19, 2026). Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1252 In the Model Optimizations chapter, I came across a mismatch between the values in Figure 13 and the text above describing it. Text description: "As shown in Figure 13 performing a 32-bit floating-point addition (FAdd) consumes approximately 0.9 pJ, whereas a 16-bit floating-point addition only requires 0.4 pJ. Similarly, a 32-bit integer addition costs 0.1 pJ, while an 8-bit integer addition is significantly lower at just 0.03 pJ." Figure 13 actual values: <img width="675" height="331" alt="Image" src="https://github.com/user-attachments/assets/f21b848b-9921-4db0-83b0-e8787576afca" /> Figure 13 shows **integer** operations, **not floating-point** operations. So either the figure or text needs changed to reflect this. Hope this helps! Tess
GiteaMirror added the area: booktype: errata labels 2026-04-11 08:06:30 -05:00
Author
Owner

@profvjreddi commented on GitHub (Mar 28, 2026):

You rock! Thanks for taking a close look at this. This is fixed in the latest dev branch and will be resolved when I push the next release. I always wondered who would catch this — I knew I wanted to fix it, but kept telling myself, "I'll get to it." And finally, someone caught it! 😄 Love it when you folks find mistakes or "bugs" in the prose.

@all-contributors please add @Tess314 as a contributor for 🪲 Bug in Book

<!-- gh-comment-id:4148676275 --> @profvjreddi commented on GitHub (Mar 28, 2026): You rock! Thanks for taking a close look at this. This is fixed in the latest dev branch and will be resolved when I push the next release. I always wondered who would catch this — I knew I wanted to fix it, but kept telling myself, "I'll get to it." And finally, someone caught it! 😄 Love it when you folks find mistakes or "bugs" in the prose. @all-contributors please add @Tess314 as a contributor for 🪲 Bug in Book
Author
Owner

@github-actions[bot] commented on GitHub (Mar 28, 2026):

I've added @Tess314 as a contributor to book! 🎉

Recognized for: doc
Project(s): book (explicitly mentioned in comment)
Based on: @all-contributors please add @Tess314 as a contributor for 🪲 Bug in Book

The contributor list has been updated in:

  • book/.all-contributorsrc, book/README.md
  • Main README.md

We love recognizing our contributors! ❤️

<!-- gh-comment-id:4148680769 --> @github-actions[bot] commented on GitHub (Mar 28, 2026): I've added @Tess314 as a contributor to **book**! :tada: **Recognized for:** doc **Project(s):** book (explicitly mentioned in comment) **Based on:** @all-contributors please add @Tess314 as a contributor for 🪲 Bug in Book The contributor list has been updated in: - `book/.all-contributorsrc`, `book/README.md` - Main `README.md` We love recognizing our contributors! :heart:
Author
Owner

@Tess314 commented on GitHub (Mar 30, 2026):

Great, thank you!

<!-- gh-comment-id:4154035225 --> @Tess314 commented on GitHub (Mar 30, 2026): Great, thank you!
Author
Owner

@Tess314 commented on GitHub (Mar 30, 2026):

Hi @profvjreddi it looks like the README files haven't been updated to add me as contributor for 🪲 Bug in Book yet

<!-- gh-comment-id:4154100336 --> @Tess314 commented on GitHub (Mar 30, 2026): Hi @profvjreddi it looks like the README files haven't been updated to add me as contributor for 🪲 Bug in Book yet
Author
Owner

@profvjreddi commented on GitHub (Apr 5, 2026):

Hey @Tess314 let me look into this. I'm curious why this is happening.

<!-- gh-comment-id:4189027588 --> @profvjreddi commented on GitHub (Apr 5, 2026): Hey @Tess314 let me look into this. I'm curious why this is happening.
Author
Owner

@profvjreddi commented on GitHub (Apr 5, 2026):

Thanks for flagging this—I’ve updated the contributor list so you’re credited as 🪲 Bug Hunter and ✍️ Doc Wizard, switched your entry to your GitHub profile photo (the old table used Gravatar identicons, not GitHub avatars), removed the duplicate name row, and linked your bug reports in the acknowledgements. 💪

Landed in commit 709f3aabd on dev (will be on main after the usual merge).

<!-- gh-comment-id:4189040876 --> @profvjreddi commented on GitHub (Apr 5, 2026): Thanks for flagging this—I’ve updated the contributor list so you’re credited as 🪲 Bug Hunter and ✍️ Doc Wizard, switched your entry to your GitHub profile photo (the old table used Gravatar identicons, not GitHub avatars), removed the duplicate name row, and linked your bug reports in the acknowledgements. 💪 Landed in commit 709f3aabd on dev (will be on main after the usual merge).
Author
Owner

@Tess314 commented on GitHub (Apr 6, 2026):

Awesome, thank you!

<!-- gh-comment-id:4192290631 --> @Tess314 commented on GitHub (Apr 6, 2026): Awesome, thank you!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#1743