github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-07 02:03:55 -05:00
Code Issues 85 Packages Projects Releases 24 Wiki Activity

[GH-ISSUE #1228] P.1546 | Incorrect p(deny) value for the SHAP example #1738

New Issue
Closed
opened 2026-04-11 08:06:11 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-11 08:06:11 -05:00
Owner
Copy Link

Originally created by @GronuJ on GitHub (Mar 11, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1228

Image

This example for the SHAP-attribution features a numerical error (0.72 instead of 0.92)

Originally created by @GronuJ on GitHub (Mar 11, 2026). Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1228 <img width="715" height="452" alt="Image" src="https://github.com/user-attachments/assets/35a89950-3fc7-4fbe-89a3-dfa5f763331e" /> This example for the SHAP-attribution features a numerical error (0.72 instead of 0.92)
GiteaMirror added the type: bugarea: book labels 2026-04-11 08:06:11 -05:00
GiteaMirror commented 2026-04-11 08:06:15 -05:00
Author
Owner
Copy Link

@profvjreddi commented on GitHub (Mar 28, 2026):

Hey @GronuJ Pardon the slow response. I forgot to get back to you about this. Thanks for catching this! The fix has been merged. P(deny) now correctly reads 0.92 (= 1 − 0.08) in the SHAP example. Closing this one out 💪

@all-contributors please add @GronuJ as a contributor for 🪲 Bug in Book

<!-- gh-comment-id:4148743106 --> @profvjreddi commented on GitHub (Mar 28, 2026): Hey @GronuJ Pardon the slow response. I forgot to get back to you about this. Thanks for catching this! The fix has been merged. P(deny) now correctly reads 0.92 (= 1 − 0.08) in the SHAP example. Closing this one out 💪 @all-contributors please add @GronuJ as a contributor for 🪲 Bug in Book
GiteaMirror commented 2026-04-11 08:06:17 -05:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Mar 28, 2026):

I've added @GronuJ as a contributor to book! 🎉

Recognized for: doc
Project(s): book (explicitly mentioned in comment)
Based on: @all-contributors please add @GronuJ as a contributor for 🪲 Bug in Book

The contributor list has been updated in:

  • book/.all-contributorsrc, book/README.md
  • Main README.md

We love recognizing our contributors! ❤️

<!-- gh-comment-id:4148747141 --> @github-actions[bot] commented on GitHub (Mar 28, 2026): I've added @GronuJ as a contributor to **book**! :tada: **Recognized for:** doc **Project(s):** book (explicitly mentioned in comment) **Based on:** @all-contributors please add @GronuJ as a contributor for 🪲 Bug in Book The contributor list has been updated in: - `book/.all-contributorsrc`, `book/README.md` - Main `README.md` We love recognizing our contributors! :heart:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label area: book type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#1738
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?