github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-17 16:34:48 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1678] [MERGED] fix(mlsysim): replace hardcoded Mac path in interviewer.py with relative Path #17365

New Issue
Closed
opened 2026-05-24 12:09:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-24 12:09:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1678
Author: @Shashank-Tripathi-07
Created: 5/5/2026
Status: ✅ Merged
Merged: 5/7/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/mlsysim-interviewer-hardcoded-path

📝 Commits (1)

  • b143875 fix(mlsysim): replace hardcoded Mac path in interviewer.py with relative Path

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 mlsysim/mlsysim/cli/interviewer.py (+3 -1)

📄 Description

Bug

mlsysim/mlsysim/cli/interviewer.py line 74 had a hardcoded Mac-specific absolute path in its __main__ smoke-test block:

corpus = InterviewCorpus("/Users/VJ/GitHub/MLSysBook/interviews/corpus.json")

This crashes immediately on any non-Mac machine (Windows, Linux, CI).

Fix

Replaced with a Path(__file__)-relative path that resolves correctly on all platforms:

_repo_root = Path(__file__).resolve().parents[3]
corpus = InterviewCorpus(_repo_root / "interviews" / "corpus.json")

Also added the missing from pathlib import Path import.

interviewer.py is at mlsysim/mlsysim/cli/interviewer.py -- .parents[3] correctly resolves to the repo root.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1678 **Author:** [@Shashank-Tripathi-07](https://github.com/Shashank-Tripathi-07) **Created:** 5/5/2026 **Status:** ✅ Merged **Merged:** 5/7/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/mlsysim-interviewer-hardcoded-path` --- ### 📝 Commits (1) - [`b143875`](https://github.com/harvard-edge/cs249r_book/commit/b143875586ad41a93ecd718c6051e9e63baa492c) fix(mlsysim): replace hardcoded Mac path in interviewer.py with relative Path ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `mlsysim/mlsysim/cli/interviewer.py` (+3 -1) </details> ### 📄 Description ## Bug `mlsysim/mlsysim/cli/interviewer.py` line 74 had a hardcoded Mac-specific absolute path in its `__main__` smoke-test block: ```python corpus = InterviewCorpus("/Users/VJ/GitHub/MLSysBook/interviews/corpus.json") ``` This crashes immediately on any non-Mac machine (Windows, Linux, CI). ## Fix Replaced with a `Path(__file__)`-relative path that resolves correctly on all platforms: ```python _repo_root = Path(__file__).resolve().parents[3] corpus = InterviewCorpus(_repo_root / "interviews" / "corpus.json") ``` Also added the missing `from pathlib import Path` import. `interviewer.py` is at `mlsysim/mlsysim/cli/interviewer.py` -- `.parents[3]` correctly resolves to the repo root. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-24 12:09:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#17365
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?