github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-18 00:44:29 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[GH-ISSUE #1128] With tinytorch 0.1.3, 06_autograd.py test_unit_function_classes should be moved after enable_autograd #16225

New Issue
Closed
opened 2026-05-24 10:20:29 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-05-24 10:20:29 -05:00
Owner
Copy Link

Originally created by @avikde on GitHub (Jan 21, 2026).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1128

Originally assigned to: @profvjreddi on GitHub.

The test_unit_function_classes() function fails if called (currently first in line 1276) before enable_autograd(quiet=True) (currently in line 2288). It appears that test_unit_function_classes() is also called from test_module(), so maybe it just does not need to be called in line 1276.

Originally created by @avikde on GitHub (Jan 21, 2026). Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/1128 Originally assigned to: @profvjreddi on GitHub. The `test_unit_function_classes()` function fails if called (currently first in line 1276) before `enable_autograd(quiet=True)` (currently in line 2288). It appears that `test_unit_function_classes()` is also called from `test_module()`, so maybe it just does not need to be called in line 1276.
GiteaMirror commented 2026-05-24 10:20:30 -05:00
Author
Owner
Copy Link

@profvjreddi commented on GitHub (Jan 21, 2026):

👍 Will look at fixing it!

<!-- gh-comment-id:3781675644 --> @profvjreddi commented on GitHub (Jan 21, 2026): 👍 Will look at fixing it!
GiteaMirror commented 2026-05-24 10:20:31 -05:00
Author
Owner
Copy Link

@profvjreddi commented on GitHub (Jan 22, 2026):

Status: Fixed ✅

You were correct. The test_unit_function_classes() function at line 1276 was being called in an if __name__ == "__main__" block, but enable_autograd() isn't called until line 2288. Since the test creates Tensors with requires_grad=True, and that parameter is only added to the Tensor class by enable_autograd(), running the file directly would fail.

Fix: Removed the premature test call. The test is already called from test_module() which runs after enable_autograd() is invoked.

Thanks for catching this!

<!-- gh-comment-id:3784231464 --> @profvjreddi commented on GitHub (Jan 22, 2026): **Status: Fixed** ✅ You were correct. The `test_unit_function_classes()` function at line 1276 was being called in an `if __name__ == "__main__"` block, but `enable_autograd()` isn't called until line 2288. Since the test creates Tensors with `requires_grad=True`, and that parameter is only added to the Tensor class by `enable_autograd()`, running the file directly would fail. **Fix:** Removed the premature test call. The test is already called from `test_module()` which runs after `enable_autograd()` is invoked. Thanks for catching this!
GiteaMirror commented 2026-05-24 10:20:31 -05:00
Author
Owner
Copy Link

@avikde commented on GitHub (Jan 22, 2026):

Thanks @profvjreddi! As I mentioned in the other issue, feel free to close the issue whenever is best for your workflow.

<!-- gh-comment-id:3784606529 --> @avikde commented on GitHub (Jan 22, 2026): Thanks @profvjreddi! As I mentioned in the other issue, feel free to close the issue whenever is best for your workflow.
GiteaMirror commented 2026-05-24 10:20:31 -05:00
Author
Owner
Copy Link

@profvjreddi commented on GitHub (Jan 22, 2026):

Also fixed in v0.1.4! Removed the premature test_unit_function_classes() call - as you noted, it's already called from test_module() after enable_autograd() runs.

(See #1127 for update instructions and contributor details!)

<!-- gh-comment-id:3787428524 --> @profvjreddi commented on GitHub (Jan 22, 2026): Also fixed in v0.1.4! Removed the premature `test_unit_function_classes()` call - as you noted, it's already called from `test_module()` after `enable_autograd()` runs. (See #1127 for update instructions and contributor details!)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#16225
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?