github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-21 05:28:28 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1752] fix(book): add body.quarto-dark selectors to video-enhanced.css dark mode #14651

New Issue
Open
opened 2026-05-17 18:26:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-17 18:26:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1752
Author: @Shashank-Tripathi-07
Created: 5/17/2026
Status: 🔄 Open

Base: dev ← Head: fix/video-enhanced-quarto-dark-toggle

📝 Commits (1)

  • aabc89c fix(book): add body.quarto-dark selectors to video-enhanced.css dark mode

📊 Changes

1 file changed (+19 additions, -0 deletions)

View changed files

📝 book/quarto/assets/styles/video-enhanced.css (+19 -0)

📄 Description

Bug

Video component containers do not apply dark styling when the reader uses Quarto's manual dark mode toggle button.

video-enhanced.css used only @media (prefers-color-scheme: dark) for its dark mode rules. The toggle button adds body.quarto-dark to the body element -- not a media query -- so OS-light users who toggle dark mode see video components rendered with light-mode styles (light gradient background, dark text) against a dark page.

Fix

Duplicate the dark mode rules under body.quarto-dark selectors directly below the existing @media block. Both mechanisms now cover the same visual states:

  • @media (prefers-color-scheme: dark) -- OS-level system preference
  • body.quarto-dark -- Quarto manual toggle

Test plan

  • Open a page containing a video-enhanced-container with OS in light mode
  • Click the dark mode toggle -- verify video container switches to dark gradient and light text
  • Toggle back to light -- verify video container returns to light styling

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1752 **Author:** [@Shashank-Tripathi-07](https://github.com/Shashank-Tripathi-07) **Created:** 5/17/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `fix/video-enhanced-quarto-dark-toggle` --- ### 📝 Commits (1) - [`aabc89c`](https://github.com/harvard-edge/cs249r_book/commit/aabc89c1e0e38deb992ef7890a6641b1dded7cd8) fix(book): add body.quarto-dark selectors to video-enhanced.css dark mode ### 📊 Changes **1 file changed** (+19 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `book/quarto/assets/styles/video-enhanced.css` (+19 -0) </details> ### 📄 Description ## Bug Video component containers do not apply dark styling when the reader uses Quarto's **manual dark mode toggle button**. `video-enhanced.css` used only `@media (prefers-color-scheme: dark)` for its dark mode rules. The toggle button adds `body.quarto-dark` to the body element -- not a media query -- so OS-light users who toggle dark mode see video components rendered with light-mode styles (light gradient background, dark text) against a dark page. ## Fix Duplicate the dark mode rules under `body.quarto-dark` selectors directly below the existing `@media` block. Both mechanisms now cover the same visual states: - `@media (prefers-color-scheme: dark)` -- OS-level system preference - `body.quarto-dark` -- Quarto manual toggle ## Test plan - [ ] Open a page containing a `video-enhanced-container` with OS in light mode - [ ] Click the dark mode toggle -- verify video container switches to dark gradient and light text - [ ] Toggle back to light -- verify video container returns to light styling --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-17 18:26:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#14651
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?