All callout boxes (Learning Objectives, Quiz Question, Checkpoint, Definition, etc.) render incorrectly when the reader uses Quarto's manual dark mode toggle button.
The toggle adds body.quarto-dark to the body element, but foldbox.css and the Lua-generated inline <style> block both used only @media (prefers-color-scheme: dark) for dark mode detection. That media query fires on OS-level system preference only. When a reader is on a light-mode OS and clicks the toggle:
Callout summary headers render with near-white #f0f0f0 text on a near-white background -- completely invisible
Callout content body does not switch to the dark background color
Expand/collapse arrows remain dark-colored instead of light
Root cause
Two files were affected:
foldbox.css -- structural dark rules (base text color, content background, arrows) only under @media (prefers-color-scheme: dark).
foldbox.lua -- per-callout dark rules (border color, background opacity, summary text, code color) generated dynamically from YAML and emitted into an inline <style> block, again only under @media (prefers-color-scheme: dark).
Fix
foldbox.css: Duplicate all dark mode rules under body.quarto-dark selectors alongside the existing @media block.
foldbox.lua: Refactor generateDarkModeCSS() to extract per-callout rule emission into a shared emitCalloutRules(prefix) helper. Call it twice -- once inside @media (prefers-color-scheme: dark) {} and once with body.quarto-dark as the selector prefix. Adding a new callout type in YAML still requires no CSS changes.
Test plan
Open a chapter page (e.g. ML Systems) in a browser with OS light mode
Click the sun/moon toggle in the navbar to switch to dark mode
Verify Learning Objectives, Quiz Question, Checkpoint, and Definition callouts all render with readable text and correct dark backgrounds
Toggle back to light mode -- verify callouts return to light styling
Repeat with OS dark mode active and toggle to light -- verify no dark styles bleed through
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1751
**Author:** [@Shashank-Tripathi-07](https://github.com/Shashank-Tripathi-07)
**Created:** 5/17/2026
**Status:** 🔄 Open
**Base:** `dev` ← **Head:** `fix/foldbox-css-quarto-dark-toggle`
---
### 📝 Commits (1)
- [`4ed27bd`](https://github.com/harvard-edge/cs249r_book/commit/4ed27bda32eae54697f01f840ab116a14bb4dd3d) fix(book): add body.quarto-dark selectors to foldbox dark mode CSS
### 📊 Changes
**2 files changed** (+63 additions, -26 deletions)
<details>
<summary>View changed files</summary>
📝 `book/quarto/_extensions/mlsysbook-ext/custom-numbered-blocks/style/foldbox.css` (+28 -1)
📝 `book/quarto/_extensions/mlsysbook-ext/custom-numbered-blocks/style/foldbox.lua` (+35 -25)
</details>
### 📄 Description
## Bug
All callout boxes (Learning Objectives, Quiz Question, Checkpoint, Definition, etc.) render incorrectly when the reader uses Quarto's **manual dark mode toggle button**.
The toggle adds `body.quarto-dark` to the body element, but `foldbox.css` and the Lua-generated inline `<style>` block both used only `@media (prefers-color-scheme: dark)` for dark mode detection. That media query fires on OS-level system preference only. When a reader is on a light-mode OS and clicks the toggle:
- Callout summary headers render with near-white `#f0f0f0` text on a near-white background -- completely invisible
- Callout content body does not switch to the dark background color
- Expand/collapse arrows remain dark-colored instead of light
## Root cause
Two files were affected:
**`foldbox.css`** -- structural dark rules (base text color, content background, arrows) only under `@media (prefers-color-scheme: dark)`.
**`foldbox.lua`** -- per-callout dark rules (border color, background opacity, summary text, code color) generated dynamically from YAML and emitted into an inline `<style>` block, again only under `@media (prefers-color-scheme: dark)`.
## Fix
**`foldbox.css`**: Duplicate all dark mode rules under `body.quarto-dark` selectors alongside the existing `@media` block.
**`foldbox.lua`**: Refactor `generateDarkModeCSS()` to extract per-callout rule emission into a shared `emitCalloutRules(prefix)` helper. Call it twice -- once inside `@media (prefers-color-scheme: dark) {}` and once with `body.quarto-dark ` as the selector prefix. Adding a new callout type in YAML still requires no CSS changes.
## Test plan
- [ ] Open a chapter page (e.g. ML Systems) in a browser with OS light mode
- [ ] Click the sun/moon toggle in the navbar to switch to dark mode
- [ ] Verify Learning Objectives, Quiz Question, Checkpoint, and Definition callouts all render with readable text and correct dark backgrounds
- [ ] Toggle back to light mode -- verify callouts return to light styling
- [ ] Repeat with OS dark mode active and toggle to light -- verify no dark styles bleed through
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/harvard-edge/cs249r_book/pull/1751
Author: @Shashank-Tripathi-07
Created: 5/17/2026
Status: 🔄 Open
Base:
dev← Head:fix/foldbox-css-quarto-dark-toggle📝 Commits (1)
4ed27bdfix(book): add body.quarto-dark selectors to foldbox dark mode CSS📊 Changes
2 files changed (+63 additions, -26 deletions)
View changed files
📝
book/quarto/_extensions/mlsysbook-ext/custom-numbered-blocks/style/foldbox.css(+28 -1)📝
book/quarto/_extensions/mlsysbook-ext/custom-numbered-blocks/style/foldbox.lua(+35 -25)📄 Description
Bug
All callout boxes (Learning Objectives, Quiz Question, Checkpoint, Definition, etc.) render incorrectly when the reader uses Quarto's manual dark mode toggle button.
The toggle adds
body.quarto-darkto the body element, butfoldbox.cssand the Lua-generated inline<style>block both used only@media (prefers-color-scheme: dark)for dark mode detection. That media query fires on OS-level system preference only. When a reader is on a light-mode OS and clicks the toggle:#f0f0f0text on a near-white background -- completely invisibleRoot cause
Two files were affected:
foldbox.css-- structural dark rules (base text color, content background, arrows) only under@media (prefers-color-scheme: dark).foldbox.lua-- per-callout dark rules (border color, background opacity, summary text, code color) generated dynamically from YAML and emitted into an inline<style>block, again only under@media (prefers-color-scheme: dark).Fix
foldbox.css: Duplicate all dark mode rules underbody.quarto-darkselectors alongside the existing@mediablock.foldbox.lua: RefactorgenerateDarkModeCSS()to extract per-callout rule emission into a sharedemitCalloutRules(prefix)helper. Call it twice -- once inside@media (prefers-color-scheme: dark) {}and once withbody.quarto-darkas the selector prefix. Adding a new callout type in YAML still requires no CSS changes.Test plan
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.