github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-21 00:23:30 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1742] [MERGED] Fix MLSysim docs inline code dark mode #14642

New Issue
Closed
opened 2026-05-17 18:25:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-17 18:25:55 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1742
Author: @farhan523
Created: 5/13/2026
Status: ✅ Merged
Merged: 5/14/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/mlsysim-inline-code-dark-mode

📝 Commits (1)

  • 6369eb5 Fix MLSysim docs inline code dark mode

📊 Changes

1 file changed (+27 additions, -0 deletions)

View changed files

📝 mlsysim/docs/styles/dark-mode.scss (+27 -0)

📄 Description

Summary

  • fix dark-mode styling for inline code across MLSysim docs pages
  • use stronger selectors for inline code in content, tables, and callouts
  • keep local preview-only _quarto.yml and generated notebook artifacts out of the PR

Before:

Screenshot 2026-05-13 165818

After:

Screenshot 2026-05-13 165810

Testing

  • verified the MLSysim preview remains available at http://127.0.0.1:4210/
  • confirmed the inline code contrast issue is resolved across getting-started and similar docs pages
  • confirmed the commit only includes mlsysim/docs/styles/dark-mode.scss

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1742 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/13/2026 **Status:** ✅ Merged **Merged:** 5/14/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/mlsysim-inline-code-dark-mode` --- ### 📝 Commits (1) - [`6369eb5`](https://github.com/harvard-edge/cs249r_book/commit/6369eb54bb74ceecc9f85084070572081e9bbffd) Fix MLSysim docs inline code dark mode ### 📊 Changes **1 file changed** (+27 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `mlsysim/docs/styles/dark-mode.scss` (+27 -0) </details> ### 📄 Description ## Summary - fix dark-mode styling for inline code across MLSysim docs pages - use stronger selectors for inline code in content, tables, and callouts - keep local preview-only _quarto.yml and generated notebook artifacts out of the PR **Before**: <img width="687" height="647" alt="Screenshot 2026-05-13 165818" src="https://github.com/user-attachments/assets/9eed33a7-cf52-4f06-ad69-a2bb402d3298" /> **After**: <img width="743" height="707" alt="Screenshot 2026-05-13 165810" src="https://github.com/user-attachments/assets/9a47d116-6606-496a-bc94-efbb5b2e6129" /> ## Testing - verified the MLSysim preview remains available at http://127.0.0.1:4210/ - confirmed the inline code contrast issue is resolved across getting-started and similar docs pages - confirmed the commit only includes mlsysim/docs/styles/dark-mode.scss --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-17 18:25:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#14642