github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-23 07:23:03 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1639] [MERGED] fix(instructors): readable blockquote text in dark mode #14545

New Issue
Closed
opened 2026-05-17 18:21:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-17 18:21:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1639
Author: @farhan523
Created: 5/3/2026
Status: ✅ Merged
Merged: 5/3/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/instructors-dark-mode-blockquote

📝 Commits (1)

  • ad200f4 fix(instructors): readable blockquote text in dark mode

📊 Changes

1 file changed (+13 additions, -0 deletions)

View changed files

📝 instructors/assets/styles/dark-mode.scss (+13 -0)

📄 Description

Summary

  • On the Assessment page (and anywhere else that uses markdown blockquotes), the Sample Decision Log entries rendered with dark text on the dark background, making them nearly unreadable in dark mode.
  • Add a blockquote rule to instructors/assets/styles/dark-mode.scss that applies the dark-mode body color, the elevated surface background, and an indigo left border.

Before:
Screenshot 2026-05-03 195342

After:
Screenshot 2026-05-03 195315

Test plan

  • cd instructors && quarto preview
  • Open http://localhost:6863/assessment.html in dark mode and verify both "Sample Decision Log: Excellent (30/30)" and "Sample Decision Log: Insufficient (6/30)" blockquotes are readable.
  • Confirm light mode is unchanged.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1639 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/3/2026 **Status:** ✅ Merged **Merged:** 5/3/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/instructors-dark-mode-blockquote` --- ### 📝 Commits (1) - [`ad200f4`](https://github.com/harvard-edge/cs249r_book/commit/ad200f4eb38ec0e8ae50ab2c7d992bd25858026a) fix(instructors): readable blockquote text in dark mode ### 📊 Changes **1 file changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `instructors/assets/styles/dark-mode.scss` (+13 -0) </details> ### 📄 Description ## Summary - On the Assessment page (and anywhere else that uses markdown blockquotes), the Sample Decision Log entries rendered with dark text on the dark background, making them nearly unreadable in dark mode. - Add a `blockquote` rule to `instructors/assets/styles/dark-mode.scss` that applies the dark-mode body color, the elevated surface background, and an indigo left border. Before: <img width="643" height="590" alt="Screenshot 2026-05-03 195342" src="https://github.com/user-attachments/assets/336b2280-885f-4be3-9d42-15188889d572" /> After: <img width="763" height="691" alt="Screenshot 2026-05-03 195315" src="https://github.com/user-attachments/assets/64961c03-7530-4eb4-99c8-b2174dead51b" /> ## Test plan - [ ] `cd instructors && quarto preview` - [ ] Open http://localhost:6863/assessment.html in dark mode and verify both "Sample Decision Log: Excellent (30/30)" and "Sample Decision Log: Insufficient (6/30)" blockquotes are readable. - [ ] Confirm light mode is unchanged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-17 18:21:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#14545
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?