github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-22 14:03:46 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1592] [MERGED] fix(staffml): correct mobile-0534 napkin_math numbers to match scenario #14505

New Issue
Closed
opened 2026-05-17 18:19:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-17 18:19:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1592
Author: @Shashank-Tripathi-07
Created: 4/27/2026
Status: ✅ Merged
Merged: 4/27/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/staffml-mobile-0534-napkin-math-mismatch

📝 Commits (1)

  • 01021a5 fix(staffml): correct mobile-0534 napkin_math to match scenario numbers

📊 Changes

1 file changed (+5 additions, -4 deletions)

View changed files

📝 interviews/vault/questions/mobile/mobile-0534.yaml (+5 -4)

📄 Description

Bug

mobile-0534 (The Mobile Style Transfer Jank) has a napkin_math that uses completely different numbers than the scenario:

Scenario (correct) napkin_math (wrong)
Compute 200 GOps 500 MFLOPs (1000x smaller)
Data moved 500 MB 10 MB (50x smaller)
Calculated AI 400 Ops/Byte 50 FLOPs/Byte

The correct option at correct_index: 1 already says "Arithmetic Intensity (400 Ops/Byte)", which is correct per the scenario. The napkin_math was just never updated to match.

Fix

interviews/vault/questions/mobile/mobile-0534.yaml

Updated napkin_math to use the scenario's actual numbers: 200 GOps / 500 MB = 400 Ops/Byte, then compare to A17 Pro ridge point of ~683 Ops/Byte to confirm memory-bound diagnosis.

Question text, scenario, options, and correct_index are all untouched.

Related: PR #1591 (cloud-0013 INT4 math fix) and PR #1590 (cloud-0024 correct_index fix) are companion StaffML audit fixes from the same audit pass.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1592 **Author:** [@Shashank-Tripathi-07](https://github.com/Shashank-Tripathi-07) **Created:** 4/27/2026 **Status:** ✅ Merged **Merged:** 4/27/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/staffml-mobile-0534-napkin-math-mismatch` --- ### 📝 Commits (1) - [`01021a5`](https://github.com/harvard-edge/cs249r_book/commit/01021a53d995479ef6b02e98a02523e97be56305) fix(staffml): correct mobile-0534 napkin_math to match scenario numbers ### 📊 Changes **1 file changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `interviews/vault/questions/mobile/mobile-0534.yaml` (+5 -4) </details> ### 📄 Description ## Bug `mobile-0534` (The Mobile Style Transfer Jank) has a napkin_math that uses completely different numbers than the scenario: | | Scenario (correct) | napkin_math (wrong) | |--|--|--| | Compute | 200 GOps | 500 MFLOPs (1000x smaller) | | Data moved | 500 MB | 10 MB (50x smaller) | | Calculated AI | 400 Ops/Byte | 50 FLOPs/Byte | The correct option at `correct_index: 1` already says "Arithmetic Intensity (400 Ops/Byte)", which is correct per the scenario. The napkin_math was just never updated to match. ## Fix `interviews/vault/questions/mobile/mobile-0534.yaml` Updated `napkin_math` to use the scenario's actual numbers: 200 GOps / 500 MB = 400 Ops/Byte, then compare to A17 Pro ridge point of ~683 Ops/Byte to confirm memory-bound diagnosis. **Question text, scenario, options, and correct_index are all untouched.** **Related:** PR #1591 (cloud-0013 INT4 math fix) and PR #1590 (cloud-0024 correct_index fix) are companion StaffML audit fixes from the same audit pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-17 18:19:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#14505
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?