github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-21 13:31:55 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1169] [MERGED] Fix Windows install issues #14170

New Issue
Closed
opened 2026-05-17 18:06:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-17 18:06:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1169
Author: @adil-mubashir-ch
Created: 2/12/2026
Status: ✅ Merged
Merged: 2/13/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/windows-install-issues

📝 Commits (1)

  • f2975da Fix Windows install issues

📊 Changes

2 files changed (+40 additions, -22 deletions)

View changed files

📝 tinytorch/site/extra/install.sh (+10 -2)
📝 tinytorch/tito/commands/setup.py (+30 -20)

📄 Description

Related to #1165

This PR fixes two Windows-specific installation issues when using Git Bash:

  1. Prefers python over python3 on Windows to avoid Microsoft Store alias resolution and incorrect Unix-style virtual environment paths.

  2. Prevents WinError 32 during tito setup by skipping self-reinstall on Windows when TinyTorch is already installed, using _check_package_installed() as disussed in issue .

Tested on:

  • Windows 10
  • Git Bash (Git for Windows)
  • Python 3.13 (Windows-native)

Installation now completes successfully without file-lock errors.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1169 **Author:** [@adil-mubashir-ch](https://github.com/adil-mubashir-ch) **Created:** 2/12/2026 **Status:** ✅ Merged **Merged:** 2/13/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/windows-install-issues` --- ### 📝 Commits (1) - [`f2975da`](https://github.com/harvard-edge/cs249r_book/commit/f2975daa67f0e08efd5747bf4ae87590d662a0c2) Fix Windows install issues ### 📊 Changes **2 files changed** (+40 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/site/extra/install.sh` (+10 -2) 📝 `tinytorch/tito/commands/setup.py` (+30 -20) </details> ### 📄 Description Related to #1165 This PR fixes two Windows-specific installation issues when using Git Bash: 1. Prefers `python` over `python3` on Windows to avoid Microsoft Store alias resolution and incorrect Unix-style virtual environment paths. 2. Prevents WinError 32 during `tito setup` by skipping self-reinstall on Windows when TinyTorch is already installed, using `_check_package_installed()` as disussed in issue . Tested on: - Windows 10 - Git Bash (Git for Windows) - Python 3.13 (Windows-native) Installation now completes successfully without file-lock errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-17 18:06:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#14170
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?