github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-23 15:35:52 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1116] [CLOSED] fix: fix GPT model to use Embedding Layer #14145

New Issue
Closed
opened 2026-05-17 18:05:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-17 18:05:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1116
Author: @minhdang26403
Created: 1/19/2026
Status: ❌ Closed

Base: dev ← Head: fix/gpt

📝 Commits (1)

  • 3bbb0ae fix: fix GPT model to use Embedding Layer created in module 11 instead of re-defining token embedding and positional embedding

📊 Changes

1 file changed (+17 additions, -27 deletions)

View changed files

📝 tinytorch/src/13_transformers/13_transformers.py (+17 -27)

📄 Description

  • Instead of re-defining token embedding and positional embedding, the GPT should use the EmbeddingLayer class defined in module 11
  • All Transformers module test passed and there is no regression

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1116 **Author:** [@minhdang26403](https://github.com/minhdang26403) **Created:** 1/19/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/gpt` --- ### 📝 Commits (1) - [`3bbb0ae`](https://github.com/harvard-edge/cs249r_book/commit/3bbb0ae27aa85d8da10b591ec5323a18f86d4728) fix: fix GPT model to use Embedding Layer created in module 11 instead of re-defining token embedding and positional embedding ### 📊 Changes **1 file changed** (+17 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/src/13_transformers/13_transformers.py` (+17 -27) </details> ### 📄 Description - Instead of re-defining token embedding and positional embedding, the GPT should use the EmbeddingLayer class defined in module 11 - All Transformers module test passed and there is no regression --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-17 18:05:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#14145
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?