github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-21 21:43:04 -05:00
Code Issues 114 Packages Projects Releases 24 Wiki Activity

[PR #1683] [MERGED] fix(slides): readable slide-table headers on teaching/vol1/vol2 in dark mode #12957

New Issue
Closed
opened 2026-05-15 04:17:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-15 04:17:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1683
Author: @farhan523
Created: 5/5/2026
Status: ✅ Merged
Merged: 5/10/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/slides-slide-table-header-dark-mode

📝 Commits (1)

  • 1480470 fix(slides): readable slide-table headers on teaching/vol1/vol2 in dark mode

📊 Changes

1 file changed (+12 additions, -0 deletions)

View changed files

📝 slides/assets/styles/dark-mode.scss (+12 -0)

📄 Description

Summary

  • .slide-table th hardcodes color: var(--mls-text) (#111111) and dark-mode.scss only overrode the header background, leaving the heading text invisible on teaching.html, vol1.html, and vol2.html in dark mode.
  • Adds dark-mode color overrides for .slide-table th / td, switches the th bottom border to the dark accent, and recolors .dl-col a so the download links keep contrast.

Test plan

  • Open teaching.html, vol1.html, vol2.html in dark mode and confirm headers and rows are readable, including the download links.
  • Toggle to light mode and verify the existing pink header swatch is unchanged.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1683 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/5/2026 **Status:** ✅ Merged **Merged:** 5/10/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/slides-slide-table-header-dark-mode` --- ### 📝 Commits (1) - [`1480470`](https://github.com/harvard-edge/cs249r_book/commit/1480470180f2024a447f585efd40ac412ff87554) fix(slides): readable slide-table headers on teaching/vol1/vol2 in dark mode ### 📊 Changes **1 file changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `slides/assets/styles/dark-mode.scss` (+12 -0) </details> ### 📄 Description ## Summary - `.slide-table th` hardcodes `color: var(--mls-text)` (#111111) and dark-mode.scss only overrode the header background, leaving the heading text invisible on `teaching.html`, `vol1.html`, and `vol2.html` in dark mode. - Adds dark-mode `color` overrides for `.slide-table` `th` / `td`, switches the th bottom border to the dark accent, and recolors `.dl-col a` so the download links keep contrast. ## Test plan - [ ] Open `teaching.html`, `vol1.html`, `vol2.html` in dark mode and confirm headers and rows are readable, including the download links. - [ ] Toggle to light mode and verify the existing pink header swatch is unchanged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-15 04:17:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#12957
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?