[GH-ISSUE #168] Possibility of a bug in the update_contributors.py #1294

Closed
opened 2026-04-11 07:41:59 -05:00 by GiteaMirror · 5 comments
Owner

Originally created by @Naeemkh on GitHub (Mar 11, 2024).
Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/168

Originally assigned to: @uchendui on GitHub.

It appears that for some users, although the contributors' full names are being collected correctly, the contributors list is using the username instead of the full name.

Originally created by @Naeemkh on GitHub (Mar 11, 2024). Original GitHub issue: https://github.com/harvard-edge/cs249r_book/issues/168 Originally assigned to: @uchendui on GitHub. It appears that for some users, although the contributors' full names are being collected correctly, the contributors list is using the username instead of the full name.
GiteaMirror added the area: book label 2026-04-11 07:41:59 -05:00
Author
Owner

@profvjreddi commented on GitHub (Mar 11, 2024):

Hmm. Yea, @uchendui knows this best so will defer to him.

<!-- gh-comment-id:1989194839 --> @profvjreddi commented on GitHub (Mar 11, 2024): Hmm. Yea, @uchendui knows this best so will defer to him.
Author
Owner

@uchendui commented on GitHub (Mar 11, 2024):

Thanks for catching this @Naeemkh. Could you please point me to an example for reference?

<!-- gh-comment-id:1989393002 --> @uchendui commented on GitHub (Mar 11, 2024): Thanks for catching this @Naeemkh. Could you please point me to an example for reference?
Author
Owner

@Naeemkh commented on GitHub (Mar 11, 2024):

Thanks, @uchendui.

For example, in my case, here is the response for API request:

{
  "login": "Naeemkh",
  "id": 6773835,
  "node_id": "MDQ6VXNlcjY3NzM4MzU=",
  "avatar_url": "https://avatars.githubusercontent.com/u/6773835?v=4",
  "gravatar_id": "",
  "url": "https://api.github.com/users/Naeemkh",
  "html_url": "https://github.com/Naeemkh",
  "followers_url": "https://api.github.com/users/Naeemkh/followers",
  "following_url": "https://api.github.com/users/Naeemkh/following{/other_user}",
  "gists_url": "https://api.github.com/users/Naeemkh/gists{/gist_id}",
  "starred_url": "https://api.github.com/users/Naeemkh/starred{/owner}{/repo}",
  "subscriptions_url": "https://api.github.com/users/Naeemkh/subscriptions",
  "organizations_url": "https://api.github.com/users/Naeemkh/orgs",
  "repos_url": "https://api.github.com/users/Naeemkh/repos",
  "events_url": "https://api.github.com/users/Naeemkh/events{/privacy}",
  "received_events_url": "https://api.github.com/users/Naeemkh/received_events",
  "type": "User",
  "site_admin": false,
  "name": "Naeem Khoshnevis",
  "company": "Harvard University",
  "blog": "",
  "location": "USA, MA, Cambridge",
  "email": null,
  "hireable": true,
  "bio": "Senior Research Software Engineer\r\n    \r\n\r\n",
  "twitter_username": null,
  "public_repos": 25,
  "public_gists": 3,
  "followers": 23,
  "following": 91,
  "created_at": "2014-02-24T17:24:35Z",
  "updated_at": "2024-02-26T13:30:31Z"
}

As you can see, the name field is given ("name": "Naeem Khoshnevis"), however, the code eventually uses my username which is "login": "Naeemkh".

<!-- gh-comment-id:1989552976 --> @Naeemkh commented on GitHub (Mar 11, 2024): Thanks, @uchendui. For example, in my case, here is the response for API request: ``` { "login": "Naeemkh", "id": 6773835, "node_id": "MDQ6VXNlcjY3NzM4MzU=", "avatar_url": "https://avatars.githubusercontent.com/u/6773835?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Naeemkh", "html_url": "https://github.com/Naeemkh", "followers_url": "https://api.github.com/users/Naeemkh/followers", "following_url": "https://api.github.com/users/Naeemkh/following{/other_user}", "gists_url": "https://api.github.com/users/Naeemkh/gists{/gist_id}", "starred_url": "https://api.github.com/users/Naeemkh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Naeemkh/subscriptions", "organizations_url": "https://api.github.com/users/Naeemkh/orgs", "repos_url": "https://api.github.com/users/Naeemkh/repos", "events_url": "https://api.github.com/users/Naeemkh/events{/privacy}", "received_events_url": "https://api.github.com/users/Naeemkh/received_events", "type": "User", "site_admin": false, "name": "Naeem Khoshnevis", "company": "Harvard University", "blog": "", "location": "USA, MA, Cambridge", "email": null, "hireable": true, "bio": "Senior Research Software Engineer\r\n \r\n\r\n", "twitter_username": null, "public_repos": 25, "public_gists": 3, "followers": 23, "following": 91, "created_at": "2014-02-24T17:24:35Z", "updated_at": "2024-02-26T13:30:31Z" } ``` As you can see, the name field is given (`"name": "Naeem Khoshnevis"`), however, the code eventually uses my username which is `"login": "Naeemkh"`.
Author
Owner

@profvjreddi commented on GitHub (May 25, 2024):

@uchendui can you please look into this -- would be nice to resolve this before the release soon.

<!-- gh-comment-id:2131385616 --> @profvjreddi commented on GitHub (May 25, 2024): @uchendui can you please look into this -- would be nice to resolve this before the release soon.
Author
Owner

@Naeemkh commented on GitHub (Jul 29, 2024):

I checked the error. It seems, it collects the name that the user set during the setting the config.

git config --global user.email "Email"
git config --global user.name "Username"

I added a couple of lines to collect the full user name.

<!-- gh-comment-id:2254760490 --> @Naeemkh commented on GitHub (Jul 29, 2024): I checked the error. It seems, it collects the name that the user set during the setting the config. ``` git config --global user.email "Email" git config --global user.name "Username" ``` I added a couple of lines to collect the full user name.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#1294