68cd5fc fix(losses): clean up log_softmax implementation to have clear variable names and reuse variables
📊 Changes
1 file changed (+4 additions, -4 deletions)
View changed files
📝tinytorch/src/04_losses/ABOUT.md (+4 -4)
📄 Description
The current sample log_softmax implementation has inconsistent variable names and does not re-use the shifted tensor variable. This commit attempts to fix these issues.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1216
**Author:** [@minhdang26403](https://github.com/minhdang26403)
**Created:** 3/8/2026
**Status:** ✅ Merged
**Merged:** 3/15/2026
**Merged by:** [@profvjreddi](https://github.com/profvjreddi)
**Base:** `dev` ← **Head:** `fix/log-softmax`
---
### 📝 Commits (1)
- [`68cd5fc`](https://github.com/harvard-edge/cs249r_book/commit/68cd5fcceba954d4e51da70ef98473feb0bc58b0) fix(losses): clean up log_softmax implementation to have clear variable names and reuse variables
### 📊 Changes
**1 file changed** (+4 additions, -4 deletions)
<details>
<summary>View changed files</summary>
📝 `tinytorch/src/04_losses/ABOUT.md` (+4 -4)
</details>
### 📄 Description
The current sample `log_softmax` implementation has inconsistent variable names and does not re-use the `shifted` tensor variable. This commit attempts to fix these issues.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/harvard-edge/cs249r_book/pull/1216
Author: @minhdang26403
Created: 3/8/2026
Status: ✅ Merged
Merged: 3/15/2026
Merged by: @profvjreddi
Base:
dev← Head:fix/log-softmax📝 Commits (1)
68cd5fcfix(losses): clean up log_softmax implementation to have clear variable names and reuse variables📊 Changes
1 file changed (+4 additions, -4 deletions)
View changed files
📝
tinytorch/src/04_losses/ABOUT.md(+4 -4)📄 Description
The current sample
log_softmaximplementation has inconsistent variable names and does not re-use theshiftedtensor variable. This commit attempts to fix these issues.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.