github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-07-16 23:24:55 -05:00
Code Issues 276 Packages Projects Releases 26 Wiki Activity

[PR #1637] [MERGED] fix(book): drop non-English TikZ comment that fails codespell #11820

New Issue
Closed
opened 2026-05-12 19:30:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-12 19:30:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1637
Author: @profvjreddi
Created: 5/3/2026
Status: ✅ Merged
Merged: 5/3/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/book-tikz-codespell-leve

📝 Commits (1)

  • 139ad89 fix(book): drop non-English TikZ comment that fails codespell

📊 Changes

1 file changed (+17 additions, -21 deletions)

View changed files

📝 book/quarto/contents/vol1/nn_computation/nn_computation.qmd (+17 -21)

📄 Description

Summary

Codespell on dev started failing after #1636 was merged. Single typo flagged at book/quarto/contents/vol1/nn_computation/nn_computation.qmd:967:

to[out=105,in=190](-0.75,-0.11)coordinate(PL1)%pre plave leve plocice

The trailing %pre plave leve plocice is a Croatian inline comment in the TikZ source for fig 5.8. Codespell flags leve as a typo for level / levee. The % prefix means TikZ ignores it, so removing the comment has zero rendering impact.

Why not add to ignore list

leve could be a real English typo elsewhere in the corpus later. Surgical removal is cleaner than weakening the dictionary.

Diff

  • 1 line: drop the trailing comment after coordinate(PL1)
  • Pre-commit auto-stripped trailing whitespace across the rest of the file (same hook run); kept those changes alongside the fix since they are pure whitespace.

Test plan

  • codespell --toml pyproject.toml book/quarto/contents/vol1/nn_computation/nn_computation.qmd exits 0
  • Codespell workflow on this PR turns green
  • Fig 5.8 still renders identically (no rendering impact from a dropped % comment)

Note on figure-placement warnings

The book-check-figure-placement pre-commit hook also flags 4 pre-existing early_float warnings in #1636's content (fig-trends, fig-channel-layer-pruning, fig-iterative-pruning, fig-quantization-error-dist). Those are out of scope for this PR; tracking separately.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1637 **Author:** [@profvjreddi](https://github.com/profvjreddi) **Created:** 5/3/2026 **Status:** ✅ Merged **Merged:** 5/3/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/book-tikz-codespell-leve` --- ### 📝 Commits (1) - [`139ad89`](https://github.com/harvard-edge/cs249r_book/commit/139ad89d6b3eab00d046d66bb01215ea0ee4ccfa) fix(book): drop non-English TikZ comment that fails codespell ### 📊 Changes **1 file changed** (+17 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `book/quarto/contents/vol1/nn_computation/nn_computation.qmd` (+17 -21) </details> ### 📄 Description ## Summary Codespell on dev started failing after #1636 was merged. Single typo flagged at `book/quarto/contents/vol1/nn_computation/nn_computation.qmd:967`: ``` to[out=105,in=190](-0.75,-0.11)coordinate(PL1)%pre plave leve plocice ``` The trailing `%pre plave leve plocice` is a Croatian inline comment in the TikZ source for fig 5.8. Codespell flags `leve` as a typo for `level` / `levee`. The `%` prefix means TikZ ignores it, so removing the comment has zero rendering impact. ## Why not add to ignore list `leve` could be a real English typo elsewhere in the corpus later. Surgical removal is cleaner than weakening the dictionary. ## Diff - 1 line: drop the trailing comment after `coordinate(PL1)` - Pre-commit auto-stripped trailing whitespace across the rest of the file (same hook run); kept those changes alongside the fix since they are pure whitespace. ## Test plan - [x] `codespell --toml pyproject.toml book/quarto/contents/vol1/nn_computation/nn_computation.qmd` exits 0 - [ ] Codespell workflow on this PR turns green - [ ] Fig 5.8 still renders identically (no rendering impact from a dropped `%` comment) ## Note on figure-placement warnings The `book-check-figure-placement` pre-commit hook also flags 4 pre-existing `early_float` warnings in #1636's content (`fig-trends`, `fig-channel-layer-pruning`, `fig-iterative-pruning`, `fig-quantization-error-dist`). Those are out of scope for this PR; tracking separately. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-12 19:30:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: labs
area: socratiq
area: staffml
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
javascript
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#11820
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?