Verified the hint now accurately describes the origin of the 1.702 constant
Confirmed no other references to this incorrect claim exist in the module
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1156
**Author:** [@profvjreddi](https://github.com/profvjreddi)
**Created:** 2/4/2026
**Status:** ✅ Merged
**Merged:** 2/4/2026
**Merged by:** [@profvjreddi](https://github.com/profvjreddi)
**Base:** `dev` ← **Head:** `feature/tinytorch-core`
---
### 📝 Commits (1)
- [`c3a9230`](https://github.com/harvard-edge/cs249r_book/commit/c3a9230ea87c9a42454606b1dfee12c0c3b6b53f) fix(activations): correct misleading GELU hint about 1.702 constant
### 📊 Changes
**1 file changed** (+1 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `tinytorch/src/02_activations/02_activations.py` (+1 -1)
</details>
### 📄 Description
## Summary
- Fixes misleading hint in Module 2 GELU implementation that claimed the 1.702 constant comes from √(2/π) ≈ 0.798
- The 1.702 is actually an empirically fitted constant so that `sigmoid(1.702x) ≈ Φ(x)` (the Gaussian CDF)
- The √(2/π) constant appears in the separate **tanh-based** GELU approximation, not the sigmoid approximation used here
Fixes #1154
## Test plan
- [x] Verified the hint now accurately describes the origin of the 1.702 constant
- [x] Confirmed no other references to this incorrect claim exist in the module
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/harvard-edge/cs249r_book/pull/1156
Author: @profvjreddi
Created: 2/4/2026
Status: ✅ Merged
Merged: 2/4/2026
Merged by: @profvjreddi
Base:
dev← Head:feature/tinytorch-core📝 Commits (1)
c3a9230fix(activations): correct misleading GELU hint about 1.702 constant📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
tinytorch/src/02_activations/02_activations.py(+1 -1)📄 Description
Summary
sigmoid(1.702x) ≈ Φ(x)(the Gaussian CDF)Fixes #1154
Test plan
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.