[PR #1141] [MERGED] fix: fix Softmax's forward pass implementation #1140

New Issue

GiteaMirror · 2026-03-22T16:01:49-05:00

GiteaMirror commented

2026-03-22 16:01:49 -05:00

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1141
Author: @minhdang26403
Created: 1/26/2026
Status: ✅ Merged
Merged: 1/26/2026
Merged by: @profvjreddi

Base: dev ← Head: fix/softmax

📝 Commits (1)

0cad877 fix: fix Softmax's forward pass implementation to operate on underlying data directly

📊 Changes

1 file changed (+5 additions, -7 deletions)

View changed files

📝 tinytorch/src/02_activations/02_activations.py (+5 -7)

📄 Description

In module 6, students will implement SoftmaxBackward manually, so there is no need to work on Tensor for Softmax's forward pass implementation. We can compute on numpy array directly, which eliminates the overhead of computational graph construction.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1141 **Author:** [@minhdang26403](https://github.com/minhdang26403) **Created:** 1/26/2026 **Status:** ✅ Merged **Merged:** 1/26/2026 **Merged by:** [@profvjreddi](https://github.com/profvjreddi) **Base:** `dev` ← **Head:** `fix/softmax` --- ### 📝 Commits (1) - [`0cad877`](https://github.com/harvard-edge/cs249r_book/commit/0cad877f2f154a78b0280818f1f47f570e38acb5) fix: fix Softmax's forward pass implementation to operate on underlying data directly ### 📊 Changes **1 file changed** (+5 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/src/02_activations/02_activations.py` (+5 -7) </details> ### 📄 Description In module 6, students will implement SoftmaxBackward manually, so there is no need to work on Tensor for Softmax's forward pass implementation. We can compute on numpy array directly, which eliminates the overhead of computational graph construction. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-03-22 16:01:49 -05:00

GiteaMirror closed this issue

2026-03-22 16:01:50 -05:00

GiteaMirror referenced this issue

2026-04-11 08:25:25 -05:00

[PR #1140] [MERGED] fix: no need to clip input value of Sigmoid #2362

GiteaMirror referenced this issue

2026-04-13 13:21:57 -05:00

[PR #1140] [MERGED] fix: no need to clip input value of Sigmoid #3084

GiteaMirror referenced this issue

2026-04-16 01:56:36 -05:00

[PR #1140] [MERGED] fix: no need to clip input value of Sigmoid #3763