[PR #1105] [CLOSED] Patch tinytorch installer script for Windows-Unix Support #1122

New Issue

GiteaMirror · 2026-03-22T16:01:11-05:00

GiteaMirror commented

2026-03-22 16:01:11 -05:00

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1105
Author: @rnjema
Created: 1/8/2026
Status: ❌ Closed

Base: dev ← Head: fix-tt-win-install

📝 Commits (2)

f8f4af4 Ensure all file modifications follow Unix-style LF EOL specification
27a1bcd feat(tinytorch): add functionality support for Linux and Git Bash environments.

📊 Changes

2 files changed (+37 additions, -8 deletions)

View changed files

📝 tinytorch/.gitattributes (+2 -0)
📝 tinytorch/site/extra/install.sh (+35 -8)

📄 Description

This pull request proposes an enhancement to the installer Bash script, thus, in a way addresses #1078 as well as follows up on #1083 .

First of all the enhancement to this script assumes the user will run it on a UNIX environment, thus, for Windows users in particular, running using Git Bash or WSL should work just fine. As I have noticed, the painpoint in the original install.sh script emanates from the differences in setting up virtual environments between UNIX and Windows.

The proposed modification checks the platform before use to dynamically determine how the virtual environment must be setup, on the other hand, it forces the setup to use the Python executable defined within the scope of the virtual environment.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1105 **Author:** [@rnjema](https://github.com/rnjema) **Created:** 1/8/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix-tt-win-install` --- ### 📝 Commits (2) - [`f8f4af4`](https://github.com/harvard-edge/cs249r_book/commit/f8f4af4b268eeaf34eb3aecc793eb47e1ad6a200) Ensure all file modifications follow Unix-style LF EOL specification - [`27a1bcd`](https://github.com/harvard-edge/cs249r_book/commit/27a1bcd2d536af83769c3991949fec4ad75c9a00) feat(tinytorch): add functionality support for Linux and Git Bash environments. ### 📊 Changes **2 files changed** (+37 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `tinytorch/.gitattributes` (+2 -0) 📝 `tinytorch/site/extra/install.sh` (+35 -8) </details> ### 📄 Description This pull request proposes an enhancement to the installer Bash script, thus, in a way addresses #1078 as well as follows up on #1083 . First of all the enhancement to this script assumes the user will run it on a UNIX environment, thus, for Windows users in particular, running using Git Bash or WSL should work just fine. As I have noticed, the painpoint in the original `install.sh` script emanates from the differences in setting up virtual environments between UNIX and Windows. The proposed modification checks the platform before use to dynamically determine how the virtual environment must be setup, on the other hand, it forces the setup to use the Python executable defined within the scope of the virtual environment. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-03-22 16:01:12 -05:00

GiteaMirror closed this issue