github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-11 08:59:07 -05:00
Code Issues 81 Packages Projects Releases 24 Wiki Activity

[PR #1682] fix(slides): readable section-list tables on tinyml pages #10229

New Issue
Open
opened 2026-05-08 11:21:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-08 11:21:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/harvard-edge/cs249r_book/pull/1682
Author: @farhan523
Created: 5/5/2026
Status: 🔄 Open

Base: dev ← Head: fix/slides-tinyml-dark-mode-tables

📝 Commits (1)

  • 9f51edd fix(slides): readable section-list tables on tinyml pages in dark mode

📊 Changes

1 file changed (+51 additions, -0 deletions)

View changed files

📝 slides/assets/styles/dark-mode.scss (+51 -0)

📄 Description

Summary

  • .module-card hardcoded background: #ffffff while dark-mode.scss colored all <td> light gray, making row text invisible on tinyml-fundamentals.html (and the other tinyml-* pages that share the component).
  • Adds dark-mode overrides for .module-card (background, headings, description, companion pill), .section-list (th/td color, borders, hover, sec-title, no-material), and .section-header-sm.
  • Tunes the .badge-slides, .badge-reading, and .badge-colab swatches so the Slides/Reading/Colab pills keep adequate contrast on the dark card.

Before:
Screenshot 2026-05-05 195721

After:
Screenshot 2026-05-05 195736

Test plan

  • Open tinyml-fundamentals.html in dark mode and confirm every row of every section-list is readable.
  • Spot-check tinyml-applications.html, tinyml-deploying.html, tinyml-mlops.html for the same components.
  • Toggle back to light mode and verify nothing regressed (cards still white, badges keep their original colors).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/harvard-edge/cs249r_book/pull/1682 **Author:** [@farhan523](https://github.com/farhan523) **Created:** 5/5/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `fix/slides-tinyml-dark-mode-tables` --- ### 📝 Commits (1) - [`9f51edd`](https://github.com/harvard-edge/cs249r_book/commit/9f51eddb8a5d8f78ca9cd25e2b28d1199502bef9) fix(slides): readable section-list tables on tinyml pages in dark mode ### 📊 Changes **1 file changed** (+51 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `slides/assets/styles/dark-mode.scss` (+51 -0) </details> ### 📄 Description ## Summary - `.module-card` hardcoded `background: #ffffff` while dark-mode.scss colored all `<td>` light gray, making row text invisible on `tinyml-fundamentals.html` (and the other `tinyml-*` pages that share the component). - Adds dark-mode overrides for `.module-card` (background, headings, description, companion pill), `.section-list` (th/td color, borders, hover, sec-title, no-material), and `.section-header-sm`. - Tunes the `.badge-slides`, `.badge-reading`, and `.badge-colab` swatches so the Slides/Reading/Colab pills keep adequate contrast on the dark card. Before: <img width="736" height="589" alt="Screenshot 2026-05-05 195721" src="https://github.com/user-attachments/assets/5b35f69a-1012-479b-aa87-7c76fb90001a" /> After: <img width="789" height="642" alt="Screenshot 2026-05-05 195736" src="https://github.com/user-attachments/assets/3c3a74d9-76ce-46e6-96d9-2f58a39f8580" /> ## Test plan - [ ] Open `tinyml-fundamentals.html` in dark mode and confirm every row of every section-list is readable. - [ ] Spot-check `tinyml-applications.html`, `tinyml-deploying.html`, `tinyml-mlops.html` for the same components. - [ ] Toggle back to light mode and verify nothing regressed (cards still white, badges keep their original colors). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-08 11:21:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: book
area: collabs
area: kits
area: socratiq
area: tinytorch
area: tools
area: website
bug
dependencies
format: epub
format: pdf
link-health
link-rot
priority-high
pull-request
Mirrored from GitHub Pull Request
 staffml
type: bug
type: citation
type: code
type: errata
type: improvement
type: new
type: question
vault-sli
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cs249r_book#10229
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?