github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-01 18:19:18 -05:00
Code Issues 77 Packages Projects Releases 24 Wiki Activity
10,613 Commits 9 Branches 31 Tags
5c19052d2a97f416a75a30202ca73f42fae3a63d
Commit Graph

8 Commits

Author SHA1 Message Date
Vijay Janapa Reddi
389989ece7 refactor(tests): clean up test folder and fix gradient flow issues 
Test Cleanup (113 files, -22,000 lines):
- Remove 21 redundant run_all_tests.py files
- Remove checkpoints/ folder (22 obsolete checkpoint files)
- Remove progressive/, debugging/, diagnostic/ folders
- Remove duplicate integration tests and examples
- Remove orphaned dev artifacts and generated outputs
- Consolidate test_gradient_flow_overall.py into system/

Documentation Cleanup (4 files removed):
- Remove duplicate HOW_TO_USE.md, WORKFLOW.md, SYSTEM_DESIGN.md
- Trim environment/README.md from 334 to 86 lines
- Update capstone/README.md removing outdated bug references

Test Fixes:
- Add requires_grad=True to layer parameters in gradient tests
- Fix PositionalEncoding argument order in test_shapes.py
- Adjust performance thresholds for realistic expectations
- Fix gradient clipping to handle memoryview correctly
- Update zero_grad assertions to accept None or zeros
 2026-01-24 12:22:37 -05:00
Vijay Janapa Reddi
42face28fb refactor(tests): remove all pytest.skip patterns for honest test results 
- Move imports to module level in all *_core.py test files (16 files)
- Remove try/except/skip patterns from integration tests
- Remove @pytest.mark.skip decorators from gradient flow tests
- Convert environment validation skips to warnings for optional checks
- Change milestone tests from skip to fail when scripts missing

Tests now either pass or fail - no silent skipping that hides issues.
This ensures the test suite provides accurate feedback about what works.
 2026-01-23 23:06:23 -05:00
Vijay Janapa Reddi
acb5142fd7 fix(tests): resolve import issues and test naming collisions 
- Fix incorrect imports (tinytorch.text/nn/data → tinytorch.core.*)
- Fix MeanSquaredError → MSELoss imports
- Fix learning_rate= → lr= for optimizer arguments
- Rename test_progressive_integration.py files to unique names
- Add missing PerformanceTestSuite classes to performance framework
- Add pytest config to tinytorch/pyproject.toml to override coverage

This resolves the pytest collection errors caused by module name conflicts.
 2026-01-23 17:59:43 -05:00
Vijay Janapa Reddi
44e5822fbc fix(tests): correct MODULE_NUMBER and MODULE_NAME in all run_all_tests.py 
Fixed copy-paste errors where MODULE metadata was incorrect:
- 01_tensor: 02 → 01
- 02_activations: 03 → 02
- 03_layers: 04 → 03
- 04_losses: Dense/Networks → Losses
- 05_dataloader: 09/Autograd → 05/DataLoader
- 06_autograd: XX → 06/Autograd
- 07_optimizers: 06/Spatial/CNN → 07/Optimizers
- 08_training: XX → 08/Training
- 09_convolutions: XX → 09/Convolutions
- 10_tokenization: XX → 10/Tokenization
- 11_embeddings: XX → 11/Embeddings
- 12_attention: XX → 12/Attention
- 13_transformers: XX → 13/Transformers
- 14_profiling: KV Caching → Profiling
- 15_quantization: Module 16 → Module 15
- 18_memoization: XX → 18/Memoization
 2026-01-23 13:17:15 -05:00
Vijay Janapa Reddi
2bc166e280 test: add test for matmul scalar rejection 
Verifies that matmul correctly raises ValueError when given 0D tensors
(scalars), ensuring behavior aligns with PyTorch/NumPy semantics.

Follow-up to PR #1120.
 2026-01-20 08:17:55 -05:00
Vijay Janapa Reddi
853eb03ee8 style: apply consistent whitespace and formatting across codebase 2025-12-13 14:05:34 -05:00
Vijay Janapa Reddi
125dd5f636 fix: correct module workflow export and milestone prerequisites 
- Fix notebook path mismatch in SrcCommand._handle_export
  (was looking for 01_tensor.ipynb but actual file is tensor.ipynb)

- Update install.sh to preserve needed files for student workflow:
  - Keep settings.ini (required for nbdev_export)
  - Keep milestones/ (required for tito milestone run)
  - Clear tinytorch/core/*.py (students rebuild via exports)
  - Clear progress.json (students start fresh)

- Fix milestone module requirements to match actual script imports:
  - Milestone 01: [1,2,3] (Tensor, Activations, Layers)
  - Milestone 02: [1,2,3,4,5,6] (+ Losses, Autograd, Optimizers)
  - Milestone 03: [1,2,3,4,5,6,8] (+ DataLoader)
  - Milestone 04: [1,2,3,4,5,6,8,9] (+ Spatial)
  - Milestone 05: [1,2,3,4,5,6,11,12,13] (+ Embeddings, Attention, Transformers)

- Fix progress file path: read from progress.json not .tito/progress.json

- Fix module number comparison: convert string IDs to integers

- Update health check to validate modules_dir (src/) not assignments_dir

- Rename 'milestones' command to 'milestone' (singular)

- Fix test files to check correct directories for student install
 2025-12-11 17:22:15 -08:00
Vijay Janapa Reddi
c602f97364 feat: integrate TinyTorch into MLSysBook repository 
TinyTorch educational deep learning framework now lives at tinytorch/

Structure:
- tinytorch/src/         - Source modules (single source of truth)
- tinytorch/tito/        - CLI tool
- tinytorch/tests/       - Test suite
- tinytorch/site/        - Jupyter Book website
- tinytorch/milestones/  - Historical ML implementations
- tinytorch/datasets/    - Educational datasets (tinydigits, tinytalks)
- tinytorch/assignments/ - NBGrader assignments
- tinytorch/instructor/  - Teaching materials

Workflows (with tinytorch- prefix):
- tinytorch-ci.yml           - CI/CD pipeline
- tinytorch-publish-dev.yml  - Dev site deployment
- tinytorch-publish-live.yml - Live site deployment
- tinytorch-build-pdf.yml    - PDF generation
- tinytorch-release-check.yml - Release validation

Repository Variables added:
- TINYTORCH_ROOT  = tinytorch
- TINYTORCH_SRC   = tinytorch/src
- TINYTORCH_SITE  = tinytorch/site
- TINYTORCH_TESTS = tinytorch/tests

All workflows use \${{ vars.TINYTORCH_* }} for path configuration.

Note: tinytorch/site/_static/favicon.svg kept as SVG (valid for favicons)
 2025-12-05 19:23:18 -08:00