2 Commits

Author	SHA1	Message	Date
Vijay Janapa Reddi	4aae33c036	test+ci: green test matrix + lint-clean + real vitest + committed lockfile ... LOCAL TEST RESULTS (all green): pytest: 34 passed in 0.19s (28 existing + 6 new command tests) ruff: All checks passed (0 errors) vitest: 7 passed in 127ms (worker contract tests) CLI e2e: vault --version / build / verify / stats / doctor / diff / export-paper / ship --dry-run / publish + verify rc1 / api shim via curl against 9199-question corpus — all green Python-side fixes: - interviews/vault-cli/pyproject.toml: ruff config now has principled per-file-ignores for B008 (Typer pattern), N806 (DAG cycle colors), E402 (scripts), SIM118 (sqlite3.Row iterator). Keeps signal tight. - 13 real ruff violations fixed across authoring.py (contextlib.suppress), diff_cmd.py + serve_api.py (dict(sqlite3.Row) instead of broken .keys() iteration), policy.py (direct return), release.py (zip strict=True, update_latest_symlink now validates target exists; previous 'target' variable was unused), commands/release.py (import order reshuffled, ambiguous 'l' renamed). - commands/release.py ship_cmd leg-skip uses 'leg' not 'l'. New pytest file: interviews/vault-cli/tests/test_commands.py (+6 tests) - stats: JSON shape + Prometheus format. - diff: add/remove/modify detection + classification. - doctor: graceful skip on missing vault; unknown --check returns USAGE_ERROR. - codegen: --check passes against baseline. Worker-side fixes: - src/index.ts cachedOrCompute graceful-degrades when caches global isn't available (Node test env, future-proofing against runtime regressions). - src/index.ts handleSearch: 'query: q' → 'query: qRaw' (q was renamed earlier). - src/rate_limit.ts: removed unused WINDOW_MS const. - tests/worker.test.ts: vi.resetModules() between tests so module-level schemaOk/lastSeenRelease state doesn't leak across test cases (fingerprint memoization was sticky). - package.json: added test:watch + lint aliases. - .gitignore: node_modules, .wrangler, dist, .dev.vars. - package-lock.json committed (npm — pnpm not on the machine; CI updated to use npm ci). CI (.github/workflows/vault-ci.yml): - Split into python + worker jobs. - Python job: ruff + mypy (non-blocking) + pytest + vault check --strict + vault build release_hash regression + vault codegen --check + registry append-only + exemplar audit staleness. - Worker job: node 20 + npm ci + tsc typecheck + vitest run. - Triggers now include staffml-vault-types path (keeps CI honest when shared-types drift). What runs vs what's gated on user: RAN LOCALLY: pytest, ruff, vitest, tsc, CLI end-to-end smoke (build→verify→export→stats→doctor→diff→publish rc→api-shim→ship --dry-run), full corpus invariants. GATED ON USER (requires Cloudflare credentials): - wrangler login + wrangler d1 create - wrangler d1 execute (schema + seed) - pnpm/npm deploy:staging - FTS5 production load-test - vault ship --env production (live D1 + Next.js + tag push) Everything that CAN be verified without credentials HAS been.	2026-04-16 14:30:20 -04:00
Vijay Janapa Reddi	42f4d1ca8b	fix(vault): Round-3 correctness + vault ship + authoring contract ... Round-3 review (4 reviewers on v2.1) surfaced two code-correctness Criticals that this commit fixes, plus the contracted-but-missing `vault ship` coordinator and David's authoring-UX gaps. Critical fixes (real bugs in landed code): worker/src/index.ts - SCHEMA_FINGERPRINT placeholder fail-closed (Chip R3-C1 / Dean R3-NH-3). Was: placeholder auto-passed and silently disabled the fingerprint check. Now: placeholder forces degraded mode until operator sets real fingerprint. - DDL hash now includes triggers (FTS5-aware). - release_id change invalidates schema-fingerprint memoization (Dean R3-NH-4). - wrangler.toml now pins the real fingerprint. staffml/public/sw.js - /manifest polling TTL-throttled to 5min (Chip R3-C2). Was: per-request fetch nullified the §10.4 cost model. - API origin persisted to IndexedDB; rehydrated on activate so cold offline wake-ups serve cached content (Chip R3-H3). vault-cli/src/vault_cli/release.py - emit_migrations diffs all 4 tables via PRAGMA-driven column introspection (Dean R3-NC-1 + R3-NH-2). Was: only questions table, silently missing chains/chain_questions/tags. Rollback-symmetry test extended to populate + verify all tables. vault-cli/src/vault_cli/commands/release.py - vault verify --git-ref reconstructs release from 'git archive <ref>' into a tempdir (Dean R3-NC-2). Was: always rebuilt from HEAD, so verifying a historical release always failed post-authoring. Academic-citability contract (C-3) now actually holds. vault-cli/src/vault_cli/ship.py (NEW) - vault ship composed verb with journaling (Dean R3-NH-1): * Legs run D1 → Next.js → paper-tag-last (§6.1.1 ordering). * Journal at releases/<v>/.ship-journal.json records per-leg state; --resume continues interrupted ships idempotently. * Pre-paper failure auto-rolls back in reverse order. * Paper-leg failure pages operator; does NOT auto-rollback earlier legs (git tag is remote-durable per §6.1.1). - 4 unit tests cover happy path, pre-paper failure auto-rollback, paper-leg needs-manual, --resume across interruptions. vault-cli/src/vault_cli/commands/authoring.py - vault new appends to id-registry.yaml (David R3-H3 + C-5 enforcement); `git pull --rebase` before allocation. - authors: auto-populated from git config user.email (David R3-H4 / M-15). Was: field never set. - vault edit injects validation-error comment block at top of YAML and re-opens up to --retries=3 times (David R3-H1). Was: terminal traceback mid-authoring session. - vault move refuses dirty tree, chained question, excluded-cell per applicability matrix (David R3-H2). Was: unchecked git mv. - vault renumber command (NEW): post-rebase seq-collision recovery. Bumps seq, renames file, updates id field, appends registry (David R3-N-2, was spec-only). - vault mark-exemplar command (NEW): promotes to vault/exemplars/ with provenance + human_reviewed_at gate (David R3-N-9). vault-cli/src/vault_cli/compiler.py - FTS5 virtual table + sync triggers added to DDL (B.5). Triggers keep questions_fts in sync via AFTER INSERT/UPDATE/DELETE. schema_fingerprint accounts for triggers now. tests/test_hashing.py - Nested-dict hash-stability fixture (Soumith R3-F-4). Was: test only reordered top-level keys + collapsed details to one key. All 28 tests pass (22 → 28: +4 ship journaling, +1 multi-table migration symmetry, +1 nested-dict hash stability). release_hash unchanged at 1b304282... — FTS5 addition doesn't affect content Merkle per §3.5 input-only design.	2026-04-16 13:10:16 -04:00