github-starred/cs249r_book
2
0
Fork 0
mirror of https://github.com/harvard-edge/cs249r_book.git synced 2026-05-06 01:28:35 -05:00
Code Issues 85 Packages Projects Releases 24 Wiki Activity

cleanup(ci): drop redundant !tinytorch/** exclude from book-validate-dev paths

Browse Source 
The path filter included `book/**` plus the two workflow YAMLs, then
`!tinytorch/**` as an exclude. The exclude was always a no-op:
tinytorch/ lives at the repo root (/tinytorch/), not under /book/, so
the `book/**` glob never matched anything in tinytorch in the first
place. GitHub's `paths`-with-`!` syntax is also strict about ordering —
an exclude only matters if a prior include would have matched, which
isn't the case here.

Removing the dead line tightens the filter to its actual semantics
(any change under book/ or to validate-dev.yml/preview-dev.yml triggers
the workflow) and prevents future-confusion about whether tinytorch
edits are gated by this workflow (they are, but via tinytorch-validate-dev,
not this one).
This commit is contained in:
Vijay Janapa Reddi
2026-05-04 22:13:15 -04:00
parent 6ae2d891cf
commit fb4be4814f
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.github/workflows/book-validate-dev.yml vendored
View File

@@ -35,7 +35,6 @@ on:
- 'book/**'
- '.github/workflows/book-validate-dev.yml'
- '.github/workflows/book-preview-dev.yml'
- '!tinytorch/**' # Exclude TinyTorch changes
workflow_dispatch: # Manual trigger for testing
inputs:
test_branch: