mirror of
https://github.com/conventional-commits/conventionalcommits.org.git
synced 2026-03-22 12:44:37 -05:00
zh/ja show unncessary spaces are generated from Markdown newlines #79
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/conventionalcommits.org#79
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Artoria2e5 on GitHub (Sep 10, 2019).
Markdown translates newlines to spaces, which works pretty well for languages that use spaces but not for others like Chinese and Japanese. These languages don't usually use spaces between words, and they definitely don't need spaces after their full-width punctuation marks that already give the space space. But, well, the nicely-newlined summary part are showing spaces everywhere as a result of this neatness. Copy the zh summary into a code editor and you will see it.
We should either ask the Markdown engine to do this (which Hugo cannot do; its CJK support is only for word count) or sacrifise this neatness of source away in these languages. Maybe we should even leave a note for translators who later do similar languages.
@damianopetrungaro commented on GitHub (Sep 12, 2019):
Hey @Artoria2e5 ! Thanks for the feedback!
Do you want to prepare a PR for that?
It would be awesome!
@Artoria2e5 commented on GitHub (Sep 12, 2019):
It is going to mess up a lot of diffs, so I figured that you can maybe @ me before a release to do that…