mirror of
https://github.com/conventional-commits/conventionalcommits.org.git
synced 2026-03-09 21:08:00 -05:00
type annotation / header file / declaration file #56
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/conventionalcommits.org#56
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Mouvedia on GitHub (Jan 22, 2019).
What's the proper type for a d.ts file* update?
What about JSDoc comments?
I think it's refactor but docs might be correct too.
* TypeScript declaration file
@stevemao commented on GitHub (Jan 22, 2019):
I'd use refactor in this case
@bcoe commented on GitHub (Feb 18, 2019):
@stevemao thanks for fielding this. @Mouvedia sounds like you both lean towards
refactor, I'd run with this 👍Keep in mind that the spec doesn't strictly define most
types, so it's more important that you're consistent in your own project, and document the approach used, rather than always come to 100% agreement on type name with folks outside your project.