mirror of
https://github.com/conventional-commits/conventionalcommits.org.git
synced 2026-05-24 08:31:12 -05:00
[PR #402] [MERGED] docs: improve example #4556
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/conventional-commits/conventionalcommits.org/pull/402
Author: @shaman-apprentice
Created: 10/3/2021
Status: ✅ Merged
Merged: 10/5/2021
Merged by: @damianopetrungaro
Base:
master← Head:docs/348/multi-paragraph-example📝 Commits (2)
179f675docs: improve example1e0a8c4docs: use "fix" type for example📊 Changes
12 files changed (+72 additions, -48 deletions)
View changed files
📝
content/next/index.md(+6 -4)📝
content/v1.0.0/index.de.md(+6 -4)📝
content/v1.0.0/index.fr.md(+6 -4)📝
content/v1.0.0/index.id.md(+6 -4)📝
content/v1.0.0/index.ja.md(+6 -4)📝
content/v1.0.0/index.ko.md(+6 -4)📝
content/v1.0.0/index.md(+6 -4)📝
content/v1.0.0/index.ru.md(+6 -4)📝
content/v1.0.0/index.th.md(+6 -4)📝
content/v1.0.0/index.uk.md(+6 -4)📝
content/v1.0.0/index.zh-hans.md(+6 -4)📝
content/v1.0.0/index.zh-hant.md(+6 -4)📄 Description
Thanks for all your input in #348. I mostly agree with you.
I think whether to start header capitalized or not is opinionated, as long as it is consistent. I find it more natural to capitalize it but e.g. Angular conventions states, it must not be capitalized. So I will leave it out of this PR. Changing it in all examples would anyway be worth an own issue and pull request in my opinion.
I felt given a shortened abstract example is nicer to read than quoting Chris Beam's exmaple.
As a side note regarding "Issues trackers can change over time". I think they shouldn't as they contain important information from also non technical stakeholders. But that's a completely different discussion :)
Thanks again for all your input! I am happy about further input.
Close #348
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.