mirror of
https://github.com/conventional-commits/conventionalcommits.org.git
synced 2026-03-22 12:44:37 -05:00
First Sumary Sentence Seems Out of Place #38
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @hutson on GitHub (Aug 19, 2018).
The first summary sentence:
Seems out of place.
I land on the
conventionalcommitswebsite and the first sentence is talking about squashing commits (something I don't do), but only for features (so what am I supposed to do for other commit types), and only talks aboutopen-source maintainers, which seems to exclude third-party contributors to a project.Can we just eliminate that sentence?
@damianopetrungaro commented on GitHub (Aug 20, 2018):
@hbetts yup, totally agree, I already asked about it.
It was partially done with #58 but we need to rephrase this instead of removing it IMHO.
A little summary it's fine to have in place ;)
@damianopetrungaro commented on GitHub (Aug 20, 2018):
This sentence too sounds strange to me:
@hutson commented on GitHub (Aug 21, 2018):
What needs to be rephrased, and how do you see it being rephrased?
@damianopetrungaro commented on GitHub (Aug 26, 2018):
@hbetts
The main issue is that the entire first block seems to be out of context and it's justified only by the last sentence of the entire introduction
that makes it easier to debug issues across project boundaries.I think this will be better:
Let's see also the other mebers think about it @conventional-commits/committee
@damianopetrungaro commented on GitHub (Aug 26, 2018):
@hbetts what o you think about
For the first sentence?
@damianopetrungaro commented on GitHub (Aug 26, 2018):
@hbetts I can open a PR for his, let me know if you are fine with those changes
@bcoe @zeke give a feedback too please 😄
@hutson commented on GitHub (Aug 27, 2018):
@damianopetrungaro I agree that there are issues in the introduction, but I was trying to keep this issue scoped to just the first sentence of the website/convention.
That sentence has the same issue of being very specific to a group of open source contributors.
If we are looking at re-wording the Introduction section, I would propose we do that, followed by taking the new content and making it the first paragraph of the Summary section, thereby eliminating the Introduction section. (My reasoning is that if you have an introduction, it should be placed first so that it introduces the rest of the website content.)
@damianopetrungaro commented on GitHub (Aug 27, 2018):
@hbetts totally agree, let's reword the first section and let's remove the
introduction.Something like this it's fine for me:
Let me know what do you think, let's see what @bcoe thinks about it, he always find some issues that we miss 😄
@damianopetrungaro commented on GitHub (Aug 28, 2018):
See #91
@bcoe commented on GitHub (Sep 16, 2018):
@hbetts @damianopetrungaro see my notes in #91, my concern about moving the introduction section to the top is that "Conventional Commits" is an attempt to describe a standard.
If you look at semver.org, the content immediately jumps into a functional description of what a user adhering to the standard should do. For this reason, I advocate that we opt for a first sentence that reads something like my proposal on #91:
I don't see a strong argument for removing the Introduction section from the conventional commits. I modeled the original document after https://semver.org/, which uses a similar structure:
We've done well for the past couple years using semver as a foundation for how we approach this specification. And semver.org has done an amazing job of gaining traction of the years. I see no reason for us to deviate from a pattern that's worked.
@hutson commented on GitHub (Sep 17, 2018):
@bcoe I like your suggestion, though I would like to propose replace
When writing software ...toWhen contributing to a project ...as not all participants in Open Source write software.