[PR #475] [MERGED] build(dev-deps): bump themes dev-deps + anchor-js #2531

New Issue

GiteaMirror · 2026-04-16T01:29:59-05:00

GiteaMirror commented

2026-04-16 01:29:59 -05:00

📋 Pull Request Information

Original PR: https://github.com/conventional-commits/conventionalcommits.org/pull/475
Author: @lorenzodianni
Created: 10/23/2022
Status: ✅ Merged
Merged: 10/23/2022
Merged by: @damianopetrungaro

Base: master ← Head: feature/update-theme-deps

📝 Commits (5)

4e9ae71 build(dev-deps): bump themes dev-deps + anchor-js
c5f517c chore: ignore .idea and .css.map files
b59ba53 build: update node to latest version
10ac2c2 build: set netflify node version
4cc392e build: remove python and g++ from prod dockerfile

📊 Changes

10 files changed (+3974 additions, -7497 deletions)

View changed files

📝 .gitignore (+1 -0)
➕ .node-version (+1 -0)
📝 Dockerfile (+2 -3)
📝 Dockerfile.dev (+2 -1)
📝 Makefile (+1 -6)
📝 themes/conventional-commits/.gitignore (+1 -0)
📝 themes/conventional-commits/package-lock.json (+3948 -7472)
📝 themes/conventional-commits/package.json (+13 -12)
📝 themes/conventional-commits/static/css/scss/components/_dropdown.scss (+3 -2)
📝 themes/conventional-commits/static/css/scss/layout/_welcome.scss (+2 -1)

📄 Description

There was a problem with node-sass and the current node version (v19) that broke local build (see #441).
To fix this error we must update how we build css, moving from node-sass (that is deprecated) to sass

I've also updated to latest version webpack and all other css dev-deps + anchor-js

We can NOT update github-markdown-css because has some breaking changes that cause some layout bugs, we need to do that in a new dedicated PR

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/conventional-commits/conventionalcommits.org/pull/475 **Author:** [@lorenzodianni](https://github.com/lorenzodianni) **Created:** 10/23/2022 **Status:** ✅ Merged **Merged:** 10/23/2022 **Merged by:** [@damianopetrungaro](https://github.com/damianopetrungaro) **Base:** `master` ← **Head:** `feature/update-theme-deps` --- ### 📝 Commits (5) - [`4e9ae71`](https://github.com/conventional-commits/conventionalcommits.org/commit/4e9ae716165fad2709b00c8cd96716e9ac447065) build(dev-deps): bump themes dev-deps + anchor-js - [`c5f517c`](https://github.com/conventional-commits/conventionalcommits.org/commit/c5f517c38d619e932a94cc0433746b663497a52d) chore: ignore .idea and .css.map files - [`b59ba53`](https://github.com/conventional-commits/conventionalcommits.org/commit/b59ba53f12f1afc620608db5a4222b497e4bd45c) build: update node to latest version - [`10ac2c2`](https://github.com/conventional-commits/conventionalcommits.org/commit/10ac2c271f9b28f87d782a0bd2a0ed6b06079eec) build: set netflify node version - [`4cc392e`](https://github.com/conventional-commits/conventionalcommits.org/commit/4cc392e0353704b0655964df4e47aff647fac45d) build: remove python and g++ from prod dockerfile ### 📊 Changes **10 files changed** (+3974 additions, -7497 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) ➕ `.node-version` (+1 -0) 📝 `Dockerfile` (+2 -3) 📝 `Dockerfile.dev` (+2 -1) 📝 `Makefile` (+1 -6) 📝 `themes/conventional-commits/.gitignore` (+1 -0) 📝 `themes/conventional-commits/package-lock.json` (+3948 -7472) 📝 `themes/conventional-commits/package.json` (+13 -12) 📝 `themes/conventional-commits/static/css/scss/components/_dropdown.scss` (+3 -2) 📝 `themes/conventional-commits/static/css/scss/layout/_welcome.scss` (+2 -1) </details> ### 📄 Description There was a problem with node-sass and the current node version (v19) that broke local build (see #441). To fix this error we must update how we build css, moving from node-sass (that is [deprecated](https://sass-lang.com/blog/libsass-is-deprecated)) to [sass](https://sass-lang.com/documentation/cli/dart-sass) I've also updated to latest version webpack and all other css dev-deps + anchor-js We can NOT update **github-markdown-css** because has some breaking changes that cause some layout bugs, we need to do that in a new dedicated PR --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-16 01:29:59 -05:00

GiteaMirror closed this issue

2026-04-16 01:30:01 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/conventionalcommits.org#2531