mirror of
https://github.com/conventional-commits/conventionalcommits.org.git
synced 2026-03-22 12:44:37 -05:00
[PR #19] [MERGED] fix(example): present tense imperative. "adds ability" -> "add ability". #246
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/conventional-commits/conventionalcommits.org/pull/19
Author: @apetro
Created: 8/28/2017
Status: ✅ Merged
Merged: 8/28/2017
Merged by: @stevemao
Base:
master← Head:present-tense-imperative-mood📝 Commits (1)
cfe269efix(example): present tense imperative. "adds ability" -> "add ability".📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
index.md(+1 -1)📄 Description
Use the present tense imperative mood in the example commit message.
So,
feat(parser): add ability to parse arrays, notfeat(parser): adds ability to parse arrays.Conventional Commits may not need to specify present tense, imperative mood for verbs. But I think at least the example should use the common present tense, imperative mood practice.
Maybe Conventional Commits should specify. Makes for a stronger convention.
References:
I added tests fororAdding tests for,useAdd tests for."🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.