github-starred/conventionalcommits.org
2
0
Fork 0
mirror of https://github.com/conventional-commits/conventionalcommits.org.git synced 2026-03-22 21:24:02 -05:00
Code Issues 153 Packages Projects Releases Wiki Activity

Best practice handling overlapped types #17

New Issue
Closed
opened 2026-02-17 11:32:33 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2026-02-17 11:32:33 -06:00
Owner
Copy Link

Originally created by @doodlewind on GitHub (Feb 21, 2018).

By default the feat and fix types are orthogonal. If we define multi types, say, test and doc, how to decide the type when committing a change that:

  • Fixes a typo - fix
  • The typo is in doc - doc
  • The doc describes unit tests - test

Shall we allow multi types in commit message, or provide suggestion choosing types?

Originally created by @doodlewind on GitHub (Feb 21, 2018). By default the `feat` and `fix` types are orthogonal. If we define multi types, say, `test` and `doc`, how to decide the type when committing a change that: * Fixes a typo - `fix` * The typo is in doc - `doc` * The doc describes unit tests - `test` Shall we allow multi types in commit message, or provide suggestion choosing types?
GiteaMirror commented 2026-02-17 11:32:35 -06:00
Author
Owner
Copy Link

@stevemao commented on GitHub (Feb 21, 2018):

say if you fix a typo of a var name or a comment in the code, it's refactor. Fix is for bug fixes.

The doc describes unit tests

If this has nothing to do with the tests themselves, it should just be docs

@stevemao commented on GitHub (Feb 21, 2018): say if you fix a typo of a var name or a comment in the code, it's `refactor`. Fix is for bug fixes. > The doc describes unit tests If this has nothing to do with the tests themselves, it should just be `docs`
GiteaMirror commented 2026-02-17 11:32:36 -06:00
Author
Owner
Copy Link

@doodlewind commented on GitHub (Feb 22, 2018):

Thanks for your suggestion, while since such change may also belong to chore, the way choosing types seems to be a bit vague?

@doodlewind commented on GitHub (Feb 22, 2018): Thanks for your suggestion, while since such change may also belong to `chore`, the way choosing types seems to be a bit vague?
GiteaMirror commented 2026-02-17 11:32:37 -06:00
Author
Owner
Copy Link

@stevemao commented on GitHub (Feb 23, 2018):

chore was supported to be changing a build or ci script. Like changing your gulpfile should be a chore.

@stevemao commented on GitHub (Feb 23, 2018): `chore` was supported to be changing a `build` or `ci` script. Like changing your gulpfile should be a `chore`.
GiteaMirror commented 2026-02-17 11:32:38 -06:00
Author
Owner
Copy Link

@damianopetrungaro commented on GitHub (May 18, 2018):

@doodlewind can we close this one or do you need other info?

@damianopetrungaro commented on GitHub (May 18, 2018): @doodlewind can we close this one or do you need other info?
GiteaMirror commented 2026-02-17 11:32:39 -06:00
Author
Owner
Copy Link

@xianshenglu commented on GitHub (Nov 22, 2020):

say if I fixed a bug in the build script, what's the type of that commit? fix or build?

@xianshenglu commented on GitHub (Nov 22, 2020): say if I fixed a bug in the build script, what's the type of that commit? `fix` or `build`?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
discussion
enhancement
greenkeeper
help wanted
meeting-agenda
operations
process
pull-request
Mirrored from GitHub Pull Request
 question
suggestion
support
triaged
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/conventionalcommits.org#17
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?