[PR #238] [MERGED] stream close handling 2: electric boogaloo #31635

New Issue

2026-07-23T05:23:19-05:00

GiteaMirror commented

2026-07-23 05:23:19 -05:00

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/238
Author: @dumbmoron
Created: 11/6/2023
Status: ✅ Merged
Merged: 11/6/2023
Merged by: @wukko

Base: current ← Head: stream-close-handling-2

📝 Commits (10+)

cae4a68 stream: improve shutdown handling, minor clean up
dbd13bc stream: send SIGKILL after timeout
7c871b6 stream: wrap abort controller in try-catch
f66ed5c stream: generalize pipe event handling
2bd8a0b stream: use descriptive variables for i/o for better readability
fb69dbd stream: use strings for signals instead of number
b662f47 types: added comments
4a9e4cd types: make streamVideoOnly more readable
7a3be8b stream: don't listen for close event for audio
e40835d package: bump to 7.6.5

📊 Changes

2 files changed (+92 additions, -75 deletions)

View changed files

📝 package.json (+2 -1)
📝 src/modules/stream/types.js (+90 -74)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/238 **Author:** [@dumbmoron](https://github.com/dumbmoron) **Created:** 11/6/2023 **Status:** ✅ Merged **Merged:** 11/6/2023 **Merged by:** [@wukko](https://github.com/wukko) **Base:** `current` ← **Head:** `stream-close-handling-2` --- ### 📝 Commits (10+) - [`cae4a68`](https://github.com/imputnet/cobalt/commit/cae4a68aa4eb672415ff8a93b8022dc97dd4a5db) stream: improve shutdown handling, minor clean up - [`dbd13bc`](https://github.com/imputnet/cobalt/commit/dbd13bc8b611ab1cd6ed91a8a1af89fc5205de32) stream: send SIGKILL after timeout - [`7c871b6`](https://github.com/imputnet/cobalt/commit/7c871b6b85d7091bf6b2f9de7a2f160f9b9afb4b) stream: wrap abort controller in try-catch - [`f66ed5c`](https://github.com/imputnet/cobalt/commit/f66ed5c414d7f5f0a03dd8949a65ebd1f478c66f) stream: generalize pipe event handling - [`2bd8a0b`](https://github.com/imputnet/cobalt/commit/2bd8a0bccdc6ff8bf6df5cdcf90f39bddd0fcdf7) stream: use descriptive variables for i/o for better readability - [`fb69dbd`](https://github.com/imputnet/cobalt/commit/fb69dbdb4f3220e3d12355f03cfd4cbb8f869ad6) stream: use strings for signals instead of number - [`b662f47`](https://github.com/imputnet/cobalt/commit/b662f472ddaca686c2db11c91e41c04f317a150b) types: added comments - [`4a9e4cd`](https://github.com/imputnet/cobalt/commit/4a9e4cd91506e5c63ec0b10156e032b1e08227fc) types: make streamVideoOnly more readable - [`7a3be8b`](https://github.com/imputnet/cobalt/commit/7a3be8b981daab6ae4e6777419805d1fe45036dd) stream: don't listen for `close` event for audio - [`e40835d`](https://github.com/imputnet/cobalt/commit/e40835dec0ea207e0fbcb60f6194ea735ed87fa5) package: bump to 7.6.5 ### 📊 Changes **2 files changed** (+92 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+2 -1) 📝 `src/modules/stream/types.js` (+90 -74) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-07-23 05:23:19 -05:00

GiteaMirror closed this issue

2026-07-23 05:23:32 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cobalt#31635