[PR #1368] [CLOSED] feat: newgrounds video & audio support #1389

Closed
opened 2025-11-09 10:12:01 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/1368
Author: @hyperdefined
Created: 6/26/2025
Status: Closed

Base: mainHead: newgrounds-support


📝 Commits (4)

  • 45a9611 feat: newgrounds video & audio support
  • 7f7a5b6 newgrounds: return proper error codes
  • 81319cb api/test: migrate newgrounds tests
  • 295ca06 newgrounds: remove unused utils function

📊 Changes

7 files changed (+221 additions, -1 deletions)

View changed files

📝 api/README.md (+1 -0)
📝 api/src/processing/match-action.js (+1 -0)
📝 api/src/processing/match.js (+12 -0)
📝 api/src/processing/service-config.js (+3 -0)
📝 api/src/processing/service-patterns.js (+6 -1)
api/src/processing/services/newgrounds.js (+156 -0)
api/src/util/tests/newgrounds.json (+42 -0)

📄 Description

copy of #682, but on my personal account because github doesn't allow collabs on organization PRs

a cleaner version of my previous pull request, no ugly history this time.

adds support for newgrounds video & music.

example links:

videos are returned as the highest quality available. support for picking the resolution could be added easily, since newgrounds stores multiple resolutions.

this pull request would close #620 (except for art, but I don't see a reason for it being added here).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/1368 **Author:** [@hyperdefined](https://github.com/hyperdefined) **Created:** 6/26/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `newgrounds-support` --- ### 📝 Commits (4) - [`45a9611`](https://github.com/imputnet/cobalt/commit/45a9611aef09c3993277af05aff4dda53cd0e35e) feat: newgrounds video & audio support - [`7f7a5b6`](https://github.com/imputnet/cobalt/commit/7f7a5b639c68e6d342933d768a200804adf58f0c) newgrounds: return proper error codes - [`81319cb`](https://github.com/imputnet/cobalt/commit/81319cb5b67fe3d5b350e6d0373d31f58fd1e6c8) api/test: migrate newgrounds tests - [`295ca06`](https://github.com/imputnet/cobalt/commit/295ca0630ea21859b65d4b0d8ac0743a9f67c4a3) newgrounds: remove unused utils function ### 📊 Changes **7 files changed** (+221 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `api/README.md` (+1 -0) 📝 `api/src/processing/match-action.js` (+1 -0) 📝 `api/src/processing/match.js` (+12 -0) 📝 `api/src/processing/service-config.js` (+3 -0) 📝 `api/src/processing/service-patterns.js` (+6 -1) ➕ `api/src/processing/services/newgrounds.js` (+156 -0) ➕ `api/src/util/tests/newgrounds.json` (+42 -0) </details> ### 📄 Description copy of #682, but on my personal account because github doesn't allow collabs on organization PRs a cleaner version of my previous pull request, no ugly history this time. adds support for newgrounds video & music. example links: * https://www.newgrounds.com/portal/view/938050 - video * https://www.newgrounds.com/audio/listen/500476 - music ~~videos are returned as the highest quality available. support for picking the resolution could be added easily, since newgrounds stores multiple resolutions.~~ this pull request would close #620 (except for art, but I don't see a reason for it being added here). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-09 10:12:01 -06:00
Sign in to join this conversation.