[PR #1365] [MERGED] api/stream: refactor and simplify ffmpeg-related code #1387

New Issue

GiteaMirror · 2025-11-09T10:11:58-06:00

GiteaMirror commented

2025-11-09 10:11:58 -06:00

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/1365
Author: @wukko
Created: 6/24/2025
Status: ✅ Merged
Merged: 6/25/2025
Merged by: @github-actions[bot]

Base: develop ← Head: refactor-api-ffmpeg

📝 Commits (6)

aa376d7 api/stream/types: huge refactor & simplification of code
14657e5 api/stream: split types.js into proxy.js and ffmpeg.js
4f4478a api/ffmpeg: fix audio codec args in remux()
d3793c7 api/ffmpeg: map video and audio in remux() with one main input
fcdf5da api/ffmpeg: refactor even more
52695cb api/service-config: replace static arrays with sets

📊 Changes

6 files changed (+268 additions, -392 deletions)

View changed files

📝 api/src/processing/match-action.js (+1 -1)
📝 api/src/processing/service-config.js (+2 -2)
➕ api/src/stream/ffmpeg.js (+216 -0)
➕ api/src/stream/proxy.js (+43 -0)
📝 api/src/stream/stream.js (+6 -7)
➖ api/src/stream/types.js (+0 -382)

📄 Description

split types.js into ffmpeg.js and proxy.js
created render() which handles ffmpeg & piping stuff
merged remux() and merge() into one function
simplified and cleaned up arguments
removed headers since they're handled by internal streams now
removed outdated arguments

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/1365 **Author:** [@wukko](https://github.com/wukko) **Created:** 6/24/2025 **Status:** ✅ Merged **Merged:** 6/25/2025 **Merged by:** [@github-actions[bot]](https://github.com/apps/github-actions) **Base:** `develop` ← **Head:** `refactor-api-ffmpeg` --- ### 📝 Commits (6) - [`aa376d7`](https://github.com/imputnet/cobalt/commit/aa376d76f6649982d360f0b173d073a9d731dbc5) api/stream/types: huge refactor & simplification of code - [`14657e5`](https://github.com/imputnet/cobalt/commit/14657e51d3d185f91aa97cd6a67391f5534ccb96) api/stream: split types.js into proxy.js and ffmpeg.js - [`4f4478a`](https://github.com/imputnet/cobalt/commit/4f4478a21dcf2c3891a7da490c63e377d0a88ca4) api/ffmpeg: fix audio codec args in remux() - [`d3793c7`](https://github.com/imputnet/cobalt/commit/d3793c7a548432f05bd8fffba1892ffa957428c6) api/ffmpeg: map video and audio in remux() with one main input - [`fcdf5da`](https://github.com/imputnet/cobalt/commit/fcdf5da73e3de862f0589a44c855ebca0cab4cd8) api/ffmpeg: refactor even more - [`52695cb`](https://github.com/imputnet/cobalt/commit/52695cbd0f2f8794b7d04ae43e570e81c63c6843) api/service-config: replace static arrays with sets ### 📊 Changes **6 files changed** (+268 additions, -392 deletions) <details> <summary>View changed files</summary> 📝 `api/src/processing/match-action.js` (+1 -1) 📝 `api/src/processing/service-config.js` (+2 -2) ➕ `api/src/stream/ffmpeg.js` (+216 -0) ➕ `api/src/stream/proxy.js` (+43 -0) 📝 `api/src/stream/stream.js` (+6 -7) ➖ `api/src/stream/types.js` (+0 -382) </details> ### 📄 Description - split types.js into ffmpeg.js and proxy.js - created render() which handles ffmpeg & piping stuff - merged remux() and merge() into one function - simplified and cleaned up arguments - removed headers since they're handled by internal streams now - removed outdated arguments --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-09 10:11:58 -06:00

GiteaMirror closed this issue

2025-11-09 10:11:59 -06:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cobalt#1387