[PR #1313] [MERGED] api/soundcloud: add more metadata fields #1376

New Issue

GiteaMirror · 2025-11-09T10:11:45-06:00

GiteaMirror commented

2025-11-09 10:11:45 -06:00

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/1313
Author: @nexpid
Created: 6/2/2025
Status: ✅ Merged
Merged: 6/8/2025
Merged by: @wukko

Base: develop ← Head: feat/more-metadata

📝 Commits (3)

55bcc66 api/soundcloud: add more metadata support
845bad8 waiter! waiter! more optional chainers please!
cfeca06 fix wording and add even more question marks

📊 Changes

4 files changed (+26 additions, -10 deletions)

View changed files

📝 api/src/processing/services/soundcloud.js (+9 -2)
📝 api/src/stream/types.js (+3 -0)
📝 docs/api.md (+11 -8)
📝 web/src/lib/types/api.ts (+3 -0)

📄 Description

this PR adds and documents the composer, genre and album_artist metadata tags. it also adds more metadata parsing to the soundcloud service:

album
album_artist
composer
genre
date
copyright

why?

having more metadata is always nice. this is a comparison with onthespot in foobar2000

onthespot	develop	feat/more-metadata

_{PS: invest in a formatter. please}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/1313 **Author:** [@nexpid](https://github.com/nexpid) **Created:** 6/2/2025 **Status:** ✅ Merged **Merged:** 6/8/2025 **Merged by:** [@wukko](https://github.com/wukko) **Base:** `develop` ← **Head:** `feat/more-metadata` --- ### 📝 Commits (3) - [`55bcc66`](https://github.com/imputnet/cobalt/commit/55bcc66cda5a63559142473005980f5f11a0a64e) api/soundcloud: add more metadata support - [`845bad8`](https://github.com/imputnet/cobalt/commit/845bad8a7e7e2324073ea96b6129df38b44da2a4) waiter! waiter! more optional chainers please! - [`cfeca06`](https://github.com/imputnet/cobalt/commit/cfeca06ac9b0fab4c1d02a447fb5fac489a2a4ed) fix wording and add even more question marks ### 📊 Changes **4 files changed** (+26 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `api/src/processing/services/soundcloud.js` (+9 -2) 📝 `api/src/stream/types.js` (+3 -0) 📝 `docs/api.md` (+11 -8) 📝 `web/src/lib/types/api.ts` (+3 -0) </details> ### 📄 Description this PR adds and documents the `composer`, `genre` and `album_artist` metadata tags. it also adds more metadata parsing to the soundcloud service: - `album` - `album_artist` - `composer` - `genre` - `date` - `copyright` ## why? having more metadata is always nice. this is a comparison with [onthespot](https://github.com/justin025/onthespot) in foobar2000 | onthespot | [develop](https://github.com/imputnet/cobalt/tree/3ee7c4d36a964fcdaae3055b3b95faf079dbaf7b) | [feat/more-metadata](https://github.com/nexpid/imputnet.cobalt/tree/feat/more-metadata) | |-|--|-| | ![foobar2000_zfKvABMRfN](https://github.com/user-attachments/assets/1da4dc60-d12b-4197-bf35-3e2766fdf9c1) | ![foobar2000_ZNfxyQ3R1x](https://github.com/user-attachments/assets/5de3b0ae-3c44-47e0-8811-b9ecb5683f45) | ![foobar2000_ohvvmuCuLl](https://github.com/user-attachments/assets/0b094dfa-ed7c-4cf4-b584-42845160710c) | <sub>PS: invest in a formatter. please</sub> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-09 10:11:45 -06:00

GiteaMirror closed this issue

2025-11-09 10:11:45 -06:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cobalt#1376