[PR #1497] [MERGED] soundcloud: fix extraction of client_id #13641

New Issue

GiteaMirror · 2026-05-15T02:42:22-05:00

GiteaMirror commented

2026-05-15 02:42:22 -05:00

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/1497
Author: @zImPatrick
Created: 1/8/2026
Status: ✅ Merged
Merged: 1/9/2026
Merged by: @wukko

Base: develop ← Head: fix-sc

📝 Commits (1)

11b3bbe api/soundcloud: fix regex & check html for hydrated client_id

📊 Changes

1 file changed (+15 additions, -12 deletions)

View changed files

📝 api/src/processing/services/soundcloud.js (+15 -12)

📄 Description

SoundCloud seems to have broken on main & develop because the regex for matching the client_id didn't match anything on newer versions anymore. This PR fixes the regex & tries to extract the client_id from hydration data first (before eventually falling back to getting it from the JS files)

The regex for matching the client_id from the hydration data is courtesy of 6d77edd0a0, thanks to @hyperdefined for it

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/1497 **Author:** [@zImPatrick](https://github.com/zImPatrick) **Created:** 1/8/2026 **Status:** ✅ Merged **Merged:** 1/9/2026 **Merged by:** [@wukko](https://github.com/wukko) **Base:** `develop` ← **Head:** `fix-sc` --- ### 📝 Commits (1) - [`11b3bbe`](https://github.com/imputnet/cobalt/commit/11b3bbe42dfcf0af7aede25006e6bc2e4ee5ca9a) api/soundcloud: fix regex & check html for hydrated client_id ### 📊 Changes **1 file changed** (+15 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `api/src/processing/services/soundcloud.js` (+15 -12) </details> ### 📄 Description SoundCloud seems to have broken on main & develop because the regex for matching the client_id didn't match anything on newer versions anymore. This PR fixes the regex & tries to extract the client_id from hydration data first (before eventually falling back to getting it from the JS files) The regex for matching the client_id from the hydration data is courtesy of https://git.canine.tools/canine.tools/cobalt/commit/6d77edd0a0fb5ac6b4083b40e66cf675281e2fed, thanks to @hyperdefined for it --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-15 02:42:22 -05:00

GiteaMirror closed this issue

2026-05-15 02:42:23 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cobalt#13641