[PR #1153] [MERGED] api/pinterest: fix video parsing (#1148) #1330

New Issue

GiteaMirror · 2025-11-09T10:10:47-06:00

GiteaMirror commented

2025-11-09 10:10:47 -06:00

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/1153
Author: @hyperdefined
Created: 3/11/2025
Status: ✅ Merged
Merged: 3/12/2025
Merged by: @dumbmoron

Base: main ← Head: fix-pinterest

📝 Commits (1)

d77b22e api/pinterest: fix video parsing (#1148)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 api/src/processing/services/pinterest.js (+1 -1)

📄 Description

This PR fixes certain Pinterest videos from returning the user's avatar instead of the video.
440d039e2c/api/src/processing/services/pinterest.js (L26)
This section was failing to get the video, as not all Pinterest videos have 720p in the URL, which failed to parse the video. It would then try to parse for images, hence returning the person who uploaded's avatar. This seems pretty safe to remove, tested on a bunch of different links and all worked fine.

This is a fix for #1148.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/1153 **Author:** [@hyperdefined](https://github.com/hyperdefined) **Created:** 3/11/2025 **Status:** ✅ Merged **Merged:** 3/12/2025 **Merged by:** [@dumbmoron](https://github.com/dumbmoron) **Base:** `main` ← **Head:** `fix-pinterest` --- ### 📝 Commits (1) - [`d77b22e`](https://github.com/imputnet/cobalt/commit/d77b22e98faad7e2608e6a11e773edfa0e47cae1) api/pinterest: fix video parsing (#1148) ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `api/src/processing/services/pinterest.js` (+1 -1) </details> ### 📄 Description This PR fixes certain Pinterest videos from returning the user's avatar instead of the video. https://github.com/imputnet/cobalt/blob/440d039e2cafa12051e7e6c1912a1673ed1eb533/api/src/processing/services/pinterest.js#L26 This section was failing to get the video, as not all Pinterest videos have `720p` in the URL, which failed to parse the video. It would then try to parse for images, hence returning the person who uploaded's avatar. This seems pretty safe to remove, tested on a bunch of different links and all worked fine. This is a fix for #1148. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-09 10:10:47 -06:00

GiteaMirror closed this issue

2025-11-09 10:10:47 -06:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cobalt#1330