[PR #802] [MERGED] web/settings/audio: disable bitrate section when not applicable #13099

New Issue

GiteaMirror · 2026-05-12T17:29:45-05:00

GiteaMirror commented

2026-05-12 17:29:45 -05:00

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/802
Author: @lathlager
Created: 10/4/2024
Status: ✅ Merged
Merged: 10/5/2024
Merged by: @wukko

Base: develop ← Head: main

📝 Commits (7)

2668780 web/settings/audio: show bitrate selection as disabled when not applicable
9862274 web/i18n/en: fix accident caused by prettier
dd821e7 web/settings/audio: fix state/settings import order
9867837 web/settings/audio: expanding SettingsCategory for better code readability
2a2f773 web/i18n/en: rephrase audio.bitrate.description
ffca3ef web/i18n/en: change word order on audio.bitrate.description
f778384 web/i18n/en: change upon to when in audio.bitrate.description

📊 Changes

2 files changed (+7 additions, -2 deletions)

View changed files

📝 web/i18n/en/settings.json (+1 -1)
📝 web/src/routes/settings/audio/+page.svelte (+6 -1)

📄 Description

please delete my closed pr thanks :3

if the audio format is either best or wav,
the bitrate selector should be greyed out,
cause it's lossless, or not necessarily re-encoded.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/802 **Author:** [@lathlager](https://github.com/lathlager) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 10/5/2024 **Merged by:** [@wukko](https://github.com/wukko) **Base:** `develop` ← **Head:** `main` --- ### 📝 Commits (7) - [`2668780`](https://github.com/imputnet/cobalt/commit/26687809252fb483a931156183e5f95c92a84fdb) web/settings/audio: show bitrate selection as disabled when not applicable - [`9862274`](https://github.com/imputnet/cobalt/commit/9862274e85f52495bb0797274a1321f2a6fb4831) web/i18n/en: fix accident caused by `prettier` - [`dd821e7`](https://github.com/imputnet/cobalt/commit/dd821e70bd8032084ccd1f8a9c55ec2224ae96bd) web/settings/audio: fix `state/settings` import order - [`9867837`](https://github.com/imputnet/cobalt/commit/9867837e83f7296417d59e2d2f6b9fece888dfc5) web/settings/audio: expanding `SettingsCategory` for better code readability - [`2a2f773`](https://github.com/imputnet/cobalt/commit/2a2f7736bc61b76d2ddbcd755f8f21d21fa69fd8) web/i18n/en: rephrase `audio.bitrate.description` - [`ffca3ef`](https://github.com/imputnet/cobalt/commit/ffca3ef0b94ffce855f51483f4eb944eb2a43539) web/i18n/en: change word order on `audio.bitrate.description` - [`f778384`](https://github.com/imputnet/cobalt/commit/f77838467fd7f0e98cf368aeba92e29e6033c467) web/i18n/en: change `upon` to `when` in `audio.bitrate.description` ### 📊 Changes **2 files changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `web/i18n/en/settings.json` (+1 -1) 📝 `web/src/routes/settings/audio/+page.svelte` (+6 -1) </details> ### 📄 Description please delete my closed pr thanks :3 if the audio format is either `best` or `wav`, the bitrate selector should be greyed out, cause it's lossless, or not necessarily re-encoded. ![format: best (not re-encoded)](https://github.com/user-attachments/assets/9ca6ca02-3249-4a78-831d-3d27d75ef93d) ![format: wav (lossless)](https://github.com/user-attachments/assets/6a688eea-0a75-40b1-a616-cc5ff7f01722) ![format mp3 (lossy)](https://github.com/user-attachments/assets/76bc53ba-b502-4ae7-90c3-10dbad703f0b) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-12 17:29:45 -05:00

GiteaMirror closed this issue

2026-05-12 17:29:45 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cobalt#13099