github-starred/cobalt
2
0
Fork 0
mirror of https://github.com/imputnet/cobalt.git synced 2026-05-21 22:07:52 -05:00
Code Issues 1.9k Packages Projects Releases Wiki Activity

[PR #909] [MERGED] api/youtube: fall back through all codecs, refactor, catch no matching formats error #1280

New Issue
Closed
opened 2025-11-09 10:09:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-09 10:09:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/909
Author: @wukko
Created: 11/13/2024
Status: ✅ Merged
Merged: 11/13/2024
Merged by: @github-actions[bot]

Base: develop ← Head: youtube-fixes

📝 Commits (9)

  • b6e827c api/youtube: improve video quality normalization once again
  • 8b972c7 api/youtube: disable hls if user prefers av1
  • 5f1c19d api/youtube: add no matching format error
  • e9d06b7 web/i18n/error/youtube: add no format error & improve hls error
  • c05f40b web/i18n/error: fix punctuation in no matching format error
  • c88e21d api/youtube/adaptive: refactor, avoid extra loops, fallback all codecs
  • dec977e api/youtube: fix variable shadowing in normalizeQuality
  • 225a721 api/tests: allow vk tests to fail
  • 3fe2bd3 api/youtube: add missing else to adaptive codec fallback

📊 Changes

3 files changed (+107 additions, -65 deletions)

View changed files

📝 api/src/processing/services/youtube.js (+99 -63)
📝 api/src/util/tests.json (+6 -0)
📝 web/i18n/en/error.json (+2 -2)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/909 **Author:** [@wukko](https://github.com/wukko) **Created:** 11/13/2024 **Status:** ✅ Merged **Merged:** 11/13/2024 **Merged by:** [@github-actions[bot]](https://github.com/apps/github-actions) **Base:** `develop` ← **Head:** `youtube-fixes` --- ### 📝 Commits (9) - [`b6e827c`](https://github.com/imputnet/cobalt/commit/b6e827c6f9d27553925bed46d772dcac8f524435) api/youtube: improve video quality normalization once again - [`8b972c7`](https://github.com/imputnet/cobalt/commit/8b972c7a85daaed9d3ef3ebfd336a041c7dcaf8f) api/youtube: disable hls if user prefers av1 - [`5f1c19d`](https://github.com/imputnet/cobalt/commit/5f1c19d0f13b8d9ceb16b637b002aae99bc54456) api/youtube: add no matching format error - [`e9d06b7`](https://github.com/imputnet/cobalt/commit/e9d06b77a86eacdde21c98af50a9d374366cabe2) web/i18n/error/youtube: add no format error & improve hls error - [`c05f40b`](https://github.com/imputnet/cobalt/commit/c05f40b2799c0ed0dc798b91e3f0326e8169c6b8) web/i18n/error: fix punctuation in no matching format error - [`c88e21d`](https://github.com/imputnet/cobalt/commit/c88e21d4a846e72aa5220725c2984e88d43d2cd9) api/youtube/adaptive: refactor, avoid extra loops, fallback all codecs - [`dec977e`](https://github.com/imputnet/cobalt/commit/dec977e34df1e8e8241200e9b09a243de45a7a85) api/youtube: fix variable shadowing in `normalizeQuality` - [`225a721`](https://github.com/imputnet/cobalt/commit/225a721805aee1ceb84910f64d21dad7e38aad16) api/tests: allow vk tests to fail - [`3fe2bd3`](https://github.com/imputnet/cobalt/commit/3fe2bd3b7c04a372747e97ba441c8e76cf008f99) api/youtube: add missing else to adaptive codec fallback ### 📊 Changes **3 files changed** (+107 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `api/src/processing/services/youtube.js` (+99 -63) 📝 `api/src/util/tests.json` (+6 -0) 📝 `web/i18n/en/error.json` (+2 -2) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-09 10:09:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
3rd party app support
bug
can reproduce
can't reproduce
documentation
duplicate
feature request
help wanted
instance hosting help
invalid
main instance issue
need more info
needs fixing
next major
not an issue
pull-request
Mirrored from GitHub Pull Request
 question
region lock issue
security
service request
skill issue
web ui
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cobalt#1280
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?