[PR #783] [CLOSED] web/Sidebar: Optimize sidebar for light mode, add "Dark Sidebar" setting #1262

New Issue

GiteaMirror · 2025-11-09T10:09:20-06:00

GiteaMirror commented

2025-11-09 10:09:20 -06:00

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/783
Author: @alectrocute
Created: 9/27/2024
Status: ❌ Closed

Base: main ← Head: AA/sidebar-actual-light-mode

📝 Commits (9)

e43c9f6 ensure sidebar is actually light in light mode
694aecf add settings toggle for this feature
ee0c755 use existing SettingsCategory, ensure setting shows up per device setting and not state
6bd695c formatting
a05e38f ensure sidebar mobile gradient is correct, remove comments in favor of more descriptive class name
5d75242 remove description (not needed lol) and optimize naming convention for new setting
281aa80 Merge branch 'main' into AA/sidebar-actual-light-mode
5d585d8 fix rounded corners
de9dc31 Merge branch 'AA/sidebar-actual-light-mode' of https://github.com/alectrocute/cobalt into AA/sidebar-actual-light-mode

📊 Changes

8 files changed (+80 additions, -43 deletions)

View changed files

📝 web/i18n/en/settings.json (+1 -0)
📝 web/src/components/icons/Cobalt.svelte (+2 -2)
📝 web/src/components/sidebar/Sidebar.svelte (+10 -4)
📝 web/src/components/sidebar/SidebarTab.svelte (+2 -2)
📝 web/src/lib/settings/defaults.ts (+3 -2)
📝 web/src/lib/types/settings.ts (+3 -2)
📝 web/src/routes/+layout.svelte (+49 -31)
📝 web/src/routes/settings/appearance/+page.svelte (+10 -0)

📄 Description

In this PR:

Add "Dark Sidebar" appearance setting
Optimize sidebar for light mode
Add additional style variables for highlighted sidebar text
Make CobaltLogo's fill set to currentColor by default

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/783 **Author:** [@alectrocute](https://github.com/alectrocute) **Created:** 9/27/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `AA/sidebar-actual-light-mode` --- ### 📝 Commits (9) - [`e43c9f6`](https://github.com/imputnet/cobalt/commit/e43c9f653ba654635ab01c1dbab8b7e8cab3578d) ensure sidebar is actually light in light mode - [`694aecf`](https://github.com/imputnet/cobalt/commit/694aecf6247eb1ff332c5255ac5a19783868830a) add settings toggle for this feature - [`ee0c755`](https://github.com/imputnet/cobalt/commit/ee0c755825ec7ec997bb9bacf1a59a69de554c70) use existing SettingsCategory, ensure setting shows up per device setting and not state - [`6bd695c`](https://github.com/imputnet/cobalt/commit/6bd695cb285014f476fb85dce2cdc508dd915275) formatting - [`a05e38f`](https://github.com/imputnet/cobalt/commit/a05e38f1669fc68d6e5653d7f13c3bb989bb707c) ensure sidebar mobile gradient is correct, remove comments in favor of more descriptive class name - [`5d75242`](https://github.com/imputnet/cobalt/commit/5d7524220dfdd73fbc8ae3c9086bfb11a2f93c5e) remove description (not needed lol) and optimize naming convention for new setting - [`281aa80`](https://github.com/imputnet/cobalt/commit/281aa800bd88f0f51222242ec3a734b450cdb1d5) Merge branch 'main' into AA/sidebar-actual-light-mode - [`5d585d8`](https://github.com/imputnet/cobalt/commit/5d585d8a6c85538b84066946e0d2d242c1c65110) fix rounded corners - [`de9dc31`](https://github.com/imputnet/cobalt/commit/de9dc3138d89d7dbf8344b36b1e1415be9ab77e1) Merge branch 'AA/sidebar-actual-light-mode' of https://github.com/alectrocute/cobalt into AA/sidebar-actual-light-mode ### 📊 Changes **8 files changed** (+80 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `web/i18n/en/settings.json` (+1 -0) 📝 `web/src/components/icons/Cobalt.svelte` (+2 -2) 📝 `web/src/components/sidebar/Sidebar.svelte` (+10 -4) 📝 `web/src/components/sidebar/SidebarTab.svelte` (+2 -2) 📝 `web/src/lib/settings/defaults.ts` (+3 -2) 📝 `web/src/lib/types/settings.ts` (+3 -2) 📝 `web/src/routes/+layout.svelte` (+49 -31) 📝 `web/src/routes/settings/appearance/+page.svelte` (+10 -0) </details> ### 📄 Description In this PR: - Add "Dark Sidebar" appearance setting - Optimize sidebar for light mode - Add additional style variables for highlighted sidebar text - Make `CobaltLogo`'s `fill` set to `currentColor` by default <img width="1507" alt="Screenshot 2024-09-27 at 3 18 40 PM" src="https://github.com/user-attachments/assets/8efc8afd-8ec5-4bf0-94d3-2a860db9df97"> <img width="1507" alt="Screenshot 2024-09-27 at 3 18 43 PM" src="https://github.com/user-attachments/assets/7ef726b7-06c0-4ef7-808e-6666441228ab"> <img width="1507" alt="Screenshot 2024-09-27 at 3 19 04 PM" src="https://github.com/user-attachments/assets/f115d475-39f4-44ce-86b3-2c43001b185f"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-09 10:09:20 -06:00

GiteaMirror closed this issue

2025-11-09 10:09:20 -06:00

GiteaMirror referenced this issue

2025-11-09 10:11:30 -06:00

[PR #1262] [MERGED] api: allow forcing on-device processing #1364

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cobalt#1262